Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Stripping PHPUnit configuration of elements #251

Open
padraic opened this issue May 11, 2017 · 3 comments
Open

Stripping PHPUnit configuration of elements #251

padraic opened this issue May 11, 2017 · 3 comments

Comments

@padraic
Copy link
Collaborator

padraic commented May 11, 2017

Humbug currently, as a first step towards building an XML configuration, strips all filter, listener and logging elements. Assess for potential problems. Do we really need to stripping out code coverage excludes, etc.? Reduce the scope for unexpected problems due to configuration tampering.

@theofidry
Copy link
Member

theofidry commented May 11, 2017

Why do we need to do so? (stripping everything I mean)

@padraic
Copy link
Collaborator Author

padraic commented May 11, 2017

At some point there was probably some notion of avoiding conflicts somewhere. Just as there is premature optimisation, there can always be an element of premature bug prevention creeping in. If there are conflicts, better to have them reported than throwing out everything which might be doing who knows what to custom listeners with a genuine purpose.

@theofidry
Copy link
Member

Ok, I think we should assume the configuration is legitimate. Maybe we could add an extension point to easily remove some things (I'm thinking of allowing a custom phpunit.xml for example). It otherwise sounds as too much extra work more likely to cause bugs and confusion (due to a greater diff between the PhpUunit config used by Humbug and the one the user expect to use).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants