-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating manual-install.zip #644
Comments
That's unfortunate. I've been using this for a few years without issue. Most of the issues aren't due to the plug-in itself but to a combination of things, e.g. PHP function version deprecation, AWS permissions / settings, file system permission, configs, conflicts, etc... |
I'm also disappointed with the decision as I never had any issues on dozens of sites using this plugin. But I can understand your decision. I'll see if I can fork and maintain it. |
Appreciate the feedback here. We'll aim not to intentionally break compatibility with anyone who wants to manually install the plugin and the SDK, and we won't require installation via Composer at the project (WordPress-wide) level. If you're not using Composer for everything else, installation into your plugins directory should be as simple as: git clone https://github.com/humanmade/S3-Uploads.git s3-uploads
cd s3-uploads
composer install (And But we'll no longer provide a prebuilt zip with this bundled, and you'll be using it this way at your own (and higher) risk. :) |
I test in my local environment, I also get the issue cannot install I'm using WordPress version 6.3 with PHP 8.2 (Laragon). After do some tweaks by fork this repository, now I can install
Here's my fork repository: https://github.com/kresnasatya/S3-Uploads/tree/update-dev-deps Here's my command to install updated wp plugin install https://github.com/kresnasatya/S3-Uploads/releases/latest/download/s3-uploads.zip --force
wp plugin activate s3-uploads
wp s3-uploads verify |
This has been merged, and the only supported installation method now is via Composer. |
We get a lot of issues around the use of manual-install.zip with various small bugs, breakages in the build system, and confusion around it. This isn't something that we use at HM, and it shows - this is why our support policy states that we use what we ship, as if this was broken for us, it'd be fixed in a matter of hours.
Right now, it's a poor experience for anyone trying to install the plugin, and isn't meeting our standards. As a result, we're going to remove this, and require the use of Composer.
If anyone in the community would like to pick up maintaining this, you're welcome to start a third-party repo that handles builds :) (Here's the old workflow for your reference.)
The text was updated successfully, but these errors were encountered: