File names with spaces in them seem to break s3 URL

[joehoyle]

If I upload the image: Logo-De-overburen-wit+payoff.png (space in the name as +). This builds the URL:

http://hmn-uploads.s3.amazonaws.com/ht/uploads/sites/3449/2014/02/Logo-De-overburen-wit+payoff.png

This 404s, it needs to be encoded as http://hmn-uploads.s3.amazonaws.com/ht/uploads/sites/3449/2014/02/Logo-De-overburen-wit%2Bpayoff.png

[wkw]

so plus symbols should probably just be converted to underscore it sounds like. the code below is what we add to every project to force lowercase filenames (causes problems with our git repos on Mac OS when clients upload files with same names, different capitalization). Should be the proper hook though to do further manipulation:

function my_sanitize_media_names($filename) {
    $info = pathinfo($filename);
    $ext  = empty($info['extension']) ? '' : '.' . $info['extension'];
    $name = basename($filename, $ext);
    return strtolower($name) . $ext;
}
add_filter('sanitize_file_name', 'my_sanitize_media_names', 10);

[joehoyle]

Another example: uploads/sites/2/2015/08/foki-då-och-nu.jpg should get some unit tests for this now.

[fklein-lu]

@joehoyle On my test install I created a post and added images with these two problematic names using "Add Media" button. I could not reproduce the issue.

Could you please verify whether this issue is still valid, and if so, provide a path to reproduce.