From 227deaa6682c21961fb264a75757e20bb8acc0b1 Mon Sep 17 00:00:00 2001 From: Kashif Rasul Date: Mon, 29 Jul 2024 18:06:14 +0200 Subject: [PATCH] fix duplicate --- src/alignment/configs.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/alignment/configs.py b/src/alignment/configs.py index 7e7e2f02..aff07920 100644 --- a/src/alignment/configs.py +++ b/src/alignment/configs.py @@ -71,7 +71,7 @@ def parse_yaml_and_args(self, yaml_arg: str, other_args: Optional[List[str]] = N inputs[arg] = [str(v) for v in val.split(",")] # bool of a non-empty string is True, so we manually check for bools - if base_type == bool: + if base_type is bool: if val in ["true", "True"]: inputs[arg] = True else: @@ -187,7 +187,8 @@ class ModelArguments: ) use_bnb_nested_quant: bool = field(default=False, metadata={"help": "use nested quantization"}) bnb_4bit_quant_storage: Optional[str] = field( - default="uint8", metadata={"help": "storage type to pack the quanitzed 4-bit prarams."} + default="uint8", + metadata={"help": "storage type to pack the quanitzed 4-bit prarams."}, ) def __post_init__(self): @@ -246,9 +247,6 @@ class SFTConfig(trl.SFTConfig): default="main", metadata={"help": ("The Hub model branch to push the model to.")}, ) - dataset_kwargs: Optional[Dict[str, Any]] = field( - default=None, metadata={"help": "Dataset kwargs for the SFTTrainer"} - ) logging_first_step: bool = field( default=True, metadata={"help": ("Whether to log and evaluate the first global_step or not.")},