Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HANDS-ON BUG] Embed youtube video in github but show details of iframe tag #200

Open
ShawnSiao opened this issue Feb 19, 2025 · 1 comment

Comments

@ShawnSiao
Copy link
Contributor

Describe the bug
Maybe we can't embed youtube videos in github, i found this way of writing in several documents. Do we need to change it to a web page jump?
What do you think? Can i fix it by this way?

To Reproduce
https://github.com/huggingface/agents-course/blob/main/units/en/unit1/tutorial.mdx

Screenshots

Image

@ShawnSiao
Copy link
Contributor Author

@burtenshaw Hi, do you think we need to fix this?

I tested several methods to try to solve this problem. In the end, I could only modify it by showing the video cover image and clicking the image to jump to view the video to provide a better reading experience. I wonder what you think?
Maybe you have a better way to solve this problem.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant