feat: NOTICKET - Remove FSync

Author: AaronKalair

internal/legacy/connstring/connstring.go

@@ -37,7 +37,6 @@ type ConnString struct {
 	Connect                 ConnectMode
 	ConnectTimeout          time.Duration
 	Database                string
-	FSync                   bool
 	HeartbeatInterval       time.Duration
 	Hosts                   []string
 	Journal                 bool
@@ -346,12 +345,6 @@ func (p *parser) addOption(pair string) error {
 			return fmt.Errorf("invalid value for %s: %s", key, value)
 		}
 		p.HeartbeatInterval = time.Duration(n) * time.Millisecond
-	case "fsync":
-		f, err := strconv.ParseBool(value)
-		if err != nil {
-			return fmt.Errorf("invalid value for %s: %s", key, value)
-		}
-		p.FSync = f
 	case "j":
 		j, err := strconv.ParseBool(value)
 		if err != nil {

internal/legacy/options/options.go

@@ -165,7 +165,6 @@ type WriteConcern struct {
 
 	w        int
 	wtimeout int
-	fsync    bool
 	journal  bool
 }
 

internal/llmgo/session.go

@@ -107,7 +107,6 @@ type getLastError struct {
 	CmdName  int         "getLastError,omitempty"
 	W        interface{} "w,omitempty"
 	WTimeout int         "wtimeout,omitempty"
-	FSync    bool        "fsync,omitempty"
 	J        bool        "j,omitempty"
 }
 
@@ -1811,7 +1810,7 @@ func (s *Session) Safe() (safe *Safe) {
 	defer s.m.Unlock()
 	if s.safeOp != nil {
 		cmd := s.safeOp.Query.(*getLastError)
-		safe = &Safe{WTimeout: cmd.WTimeout, FSync: cmd.FSync, J: cmd.J}
+		safe = &Safe{WTimeout: cmd.WTimeout, J: cmd.J}
 		switch w := cmd.W.(type) {
 		case string:
 			safe.WMode = w
@@ -1946,7 +1945,7 @@ func (s *Session) ensureSafe(safe *Safe) {
 
 	var cmd getLastError
 	if s.safeOp == nil {
-		cmd = getLastError{1, w, safe.WTimeout, safe.FSync, safe.J}
+		cmd = getLastError{1, w, safe.WTimeout, safe.J}
 	} else {
 		// Copy.  We don't want to mutate the existing query.
 		cmd = *(s.safeOp.Query.(*getLastError))
@@ -1960,10 +1959,7 @@ func (s *Session) ensureSafe(safe *Safe) {
 		if safe.WTimeout > 0 && safe.WTimeout < cmd.WTimeout {
 			cmd.WTimeout = safe.WTimeout
 		}
-		if safe.FSync {
-			cmd.FSync = true
-			cmd.J = false
-		} else if safe.J && !cmd.FSync {
+		if safe.J {
 			cmd.J = true
 		}
 	}
@@ -4469,6 +4465,7 @@ func (c *Collection) writeOpCommand(socket *MongoSocket, safeOp *QueryOp, op int
 	} else {
 		writeConcern = safeOp.Query.(*getLastError)
 	}
+    debugf("writeConcern is %+v", writeConcern)
 
 	var cmd bson.D
 	switch op := op.(type) {