Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script saves the standup, but sends no notification on Flowdock #27

Open
shanazar opened this issue Feb 23, 2016 · 3 comments
Open

Script saves the standup, but sends no notification on Flowdock #27

shanazar opened this issue Feb 23, 2016 · 3 comments

Comments

@shanazar
Copy link

My hubot("doge") works and responds to such commands as help and create standup and it acrually creates standups(but the room is "undefined", maybe that could be the thing?). But when the actual standup time comes there aren't any notifications. I have no idea where the error could be, but I haven't modified it in any way and all the dependencies are there. My guess is the error could be in either room function or standupShouldFire function.
screenshot 2016-02-23 21 34 59

@shaundon
Copy link

I love that your Hubot is named Doge 🐶

It's almost definitely because the room is undefined. The way the alarm works is by calling robot.messageRoom(roomName, messageToSend), so if the room name is undefined, it won't work.

Unfortunately I don't have Flowdock to test this, because my organisation has moved to Slack. However, we used to use this with Flowdock, so I know it worked in the past. I wonder if Flowdock has changed their Hubot connector?

Either way, it should be easily fixable by changing the findRoom function to retrieve it from whichever data structure Flowdock is using. Would you be able to find this out?

@shanazar
Copy link
Author

Can't find any documentation on how to retrieve a room ID on flowdock :/. This involves some integration wth Flowdock API which is confusing.

@hoylemd
Copy link

hoylemd commented Oct 20, 2016

I'm not seeing this issue now.

I'm doing

Hubot create standup 10:15

And then

Hubot list all standups

and I get

Here's the standups for every room:
Room: <a big GUID hash>, Time: 10:15

@shanazar Can you confirm if this is still happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants