Hipchat only announcing in PM, works great, but public channels, no announcement!

[dylanh724]

Tried making standups from PM, then announces in PM.

Tried making standup in public channel, set, but doesn't announce.

I'll make 2 at once, same time, only 1 PM 1 public, and only PM will work.

What is going on ?? Using hipchat

[dylanh724]

Found problem, public rooms are not formatted correctly:
http://i.imgur.com/vkR66SV.png

[shaundon]

Ah yeah, I'll take a look as soon as I can. Somebody else has had the same issue actually, this looks like it's the same thing

[dylanh724]

I can confirm that hard-coding the room works, so however you got the room, if you can format it the same way as the private room, bingo

[shaundon]

Just to say that I haven't forgotten about this - still working on it!

[alexandernilsson]

Ran into this problem when trying to get the plugin working for us.
Making findRoom(msg) first try msg.envelope.user.reply_to and fallback to msg.envelope.room fixed it for us. I have no idea how this would work with other adapters, but it works for HipChat.

Unfortunately I couldn't get master branch working with timezones, so I branched off from the commit I believe 0.0.7 was based off and took it from there.

[bkruger99]

Just an observation looking at the code and not having it work either (though didn't get a chance to test).

https://github.com/hubot-scripts/hubot-standup-alarm/blob/master/scripts/standup.coffee#L91

Should that be "room" or "return" ?
Looking at the rest of the code, it seems like it should be return.

[darues]

As a workaround, don't know how good this code is, I've added control in the findRoom function just before returning the value, so that if the adapterName is hipchat, we use the reply_to value that has the correct Jabber room name, so that hubot can send the alarm to chat rooms:

    if robot.adapterName == 'hipchat'
      room = msg.envelope.user.reply_to