Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images are insecure #10

Open
chapmanc opened this issue Jan 7, 2016 · 2 comments
Open

Images are insecure #10

chapmanc opened this issue Jan 7, 2016 · 2 comments

Comments

@chapmanc
Copy link

chapmanc commented Jan 7, 2016

Some of the ship-it images come from http rather than https. Security issue.
@technicalpickles
Copy link
Contributor

Many of them don't have valid https, ie http://images.cheezburger.com/completestore/2011/11/2/aa83c0c4-2123-4bd3-8097-966c9461b30c.jpg . Do you have any suggestions of how to deal with that?

What would happen if they remained behind http?

@chapmanc
Copy link
Author

chapmanc commented Jan 9, 2016

http://security.stackexchange.com/questions/38893/exploiting-http-content-in-https-page

You could host those images behind a secure site? Publicly shared dropbox? In our case I simply removed the http urls. It's not a problem mixing http/https content until it's a problem.

@dasilvacontin dasilvacontin mentioned this issue Feb 4, 2016
Open
@takouhai takouhai mentioned this issue Apr 21, 2016
Open
takouhai pushed a commit to takouhai/hubot-shipit that referenced this issue Apr 21, 2016
Make images secure, fixes hubot-archive#11 and hubot-archive#10
91bc568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@technicalpickles @chapmanc