Skip if NODE_ENV environment is "development". #7
Conversation
|
Nice, that should help with #6 ! I think the only thing left is to document how to set that in development. Unfortunately, I don't think our hubot generator or documentation does a good job of setting up or documenting how to set those. |
I suggested this in #6: Another idea I had for this is to support setting HUBOT_HEROKU_KEEPALIVE_URL=false to disable. That way, if it's unset, it'll prompt you to configure it with a real URL or false. That would avoid having another environment variable. |
|
It seems good idea! We can avoid the error with that simple way. So I close this p-r that no longer necessary. thanks :) |
Hi! I tried to fix #6.
This patch provides an option. During set
NODE_ENVas 'development', skip process without warning; Implementation for Plan A of #6But actually, I have a concern.
As a default, Heroku does not provide
NODE_ENVenvironment.Many hubot users don't use
NODE_ENVon both production(Heroku) and development(local machine) normally, I think. Then should we create brand-new environment variable? My opinion is "less is better", but there is little difference in this case.I may need your advice.
Thanks.