Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data returned by google API is blindly eval'd #1

Open
jvennix-r7 opened this issue Oct 29, 2014 · 2 comments
Open

Data returned by google API is blindly eval'd #1

jvennix-r7 opened this issue Oct 29, 2014 · 2 comments
Labels
bug help wanted

Comments

@jvennix-r7
Copy link

This could allow arbitrary code execution if google ever responded with something that could be interpreted as executable code. The offending code is here:

https://github.com/hubot-scripts/hubot-google-translate/blob/master/src/google-translate.coffee#L106

I think JSON.parse() would be the easy fix.
@therealklanni
Copy link
Member

Feel free to submit a PR for that change and someone will be happy to merge. Don't forget to update any tests. 👍

@Zuhair5030
Copy link

stunnig__soul-.-0001.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@therealklanni @jvennix-r7 @Zuhair5030