Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more methods to QueryBuilder #2032

Open
rnveach opened this issue Feb 14, 2025 · 4 comments
Open

Add more methods to QueryBuilder #2032

rnveach opened this issue Feb 14, 2025 · 4 comments

Comments

@rnveach
Copy link
Contributor

rnveach commented Feb 14, 2025

GHPullRequestQueryBuilder doesn't seem to support pageSize(int) but GHIssueQueryBuilder does.

I don't know if there is a technical reason, but it would help to support repos with a large number of PRs. I didn't realize this was a possibility at first and took a long time to start iterating through issues.

GHIssueQueryBuilder seems to still pull in PRs. Is it possible to add another method to the query to drop PRs from Issue queries and the same for Issues from PR queries. It would help the amount of data to transfer from the server if the server supported it.

@rnveach
Copy link
Contributor Author

rnveach commented Feb 16, 2025

@bitwiseman Would number 2 be pulls?
https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28

Also, if I modify the test AppTest#testQueryIssues, how do I overcome the request not matched failure?

@bitwiseman
Copy link
Member

When you modify the test, you will need to rerecord the wiremock data, or manually modify the data files. If you plan to do this, I will invite you to be a member of the hub4j-test org to be able to record.

@rnveach
Copy link
Contributor Author

rnveach commented Feb 17, 2025

I am willing to give this a try. I can make the production changes, it is just the tests I am not sure about.

@bitwiseman
Copy link
Member

Give it a try and if you get stuck submit the PR anyway and we can discuss from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants