-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting responses for update #100
Labels
Comments
first two are covered by #72 |
Tried third one with this in // Then, check to see if update happens even without validator
tests.push({
name: `HTTP cache must update and return \`${storedHeader}\` from a \`304\` even when there is no validator stored`,
id: `304-noval-use-stored-${storedHeader}`,
depends_on: [`304-lm-use-stored-${storedHeader}`],
requests: [
{
response_headers: [
['Cache-Control', 'max-age=1'],
['Date', 0],
[storedHeader, valueA]
],
setup: true,
pause_after: true
},
{
request_headers: [
['If-Modified-Since', -3000]
],
magic_ims: true,
response_status: [304, 'Not Modified'],
response_headers: [
['Cache-Control', 'max-age=1000'],
['Date', 0],
[storedHeader, valueB]
],
expected_response_headers: [
[storedHeader, valueB]
]
},
{
expected_type: 'cached',
setup_tests: ['expected_type'],
expected_response_headers: [
[storedHeader, valueB]
]
}
]
}) No proxy checked returned the 304 to the client except for Trafficserver, which thought it was an error, and didn't update the response. I think we need more nuanced validation tests before getting to this. |
Closing as not practically testable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: