Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak where did-update render modifier runs on destroyed rows #354

Open
nwhittaker opened this issue Mar 10, 2022 · 0 comments

Comments

@nwhittaker
Copy link

nwhittaker commented Mar 10, 2022

  1. Visit https://ember-twiddle.com/910cbd741907663265e1ac93d4c8600e.
  2. Scroll to the bottom of the list of inputs and make a change to the input in the last row. This will trigger an update modifier on each row to run.
  3. Open the console and see several error messages showing the update modifier ran on some rows that no longer exist in the DOM and are now instead inside a document fragment.

I was expecting the did-update modifier to only run on elements that exist in the DOM.

Reproduced in both 2.1.0 and 3.0.0-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant