Fix bug #1378 and create a regression test. (#1379)

threeifbyair · hsutter · web-flow · commit fb26c8c37bfa · 2025-04-28T17:54:45.000-10:00
* Fix bug #1378 and create a regression test. * Renamed new test file to *-error.cpp2 --------- Co-authored-by: Herb Sutter <herb.sutter@gmail.com>
diff --git a/regression-tests/pure2-bugfix-for-bad-using-error.cpp2 b/regression-tests/pure2-bugfix-for-bad-using-error.cpp2
@@ -0,0 +1,3 @@
+main: () = {
+  using
+}
diff --git a/regression-tests/test-results/pure2-bugfix-for-bad-using-error.cpp2.output b/regression-tests/test-results/pure2-bugfix-for-bad-using-error.cpp2.output
@@ -0,0 +1,3 @@
+pure2-bugfix-for-bad-using-error.cpp2...
+pure2-bugfix-for-bad-using-error.cpp2(3,1): error: expected valid id-expression after 'using' (at '}')
+
diff --git a/source/parse.h b/source/parse.h
@@ -2335,8 +2335,7 @@ struct using_statement_node
     auto for_namespace() const
         -> bool
     {
-        assert(id);
-        return id->to_string().ends_with("::_");
+        return (id && id->to_string().ends_with("::_"));
     }
 
     auto position() const

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+pure2-bugfix-for-bad-using-error.cpp2...`
	`2`	`+pure2-bugfix-for-bad-using-error.cpp2(3,1): error: expected valid id-expression after 'using' (at '}')`
	`3`	`+`
Original file line number	Diff line number	Diff line change
`@@ -2335,8 +2335,7 @@ struct using_statement_node`
`2335`	`2335`	`auto for_namespace() const`
`2336`	`2336`	`-> bool`
`2337`	`2337`	`{`
`2338`		`- assert(id);`
`2339`		`- return id->to_string().ends_with("::_");`
	`2338`	`+ return (id && id->to_string().ends_with("::_"));`
`2340`	`2339`	`}`
`2341`	`2340`
`2342`	`2341`	`auto position() const`