Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QML styles (Vector layer added via Layman is not styled) #3513

Open
jmacura opened this issue Nov 4, 2022 · 6 comments
Open

Support QML styles (Vector layer added via Layman is not styled) #3513

jmacura opened this issue Nov 4, 2022 · 6 comments
Assignees
Labels
enhancement LayerSources Issues related to Layman, Micka, WMS, WFS, etc.
Milestone

Comments

@jmacura
Copy link
Collaborator

jmacura commented Nov 4, 2022

Feature Request

Is your feature request related to a problem? Please describe.
Related to #3440
Adding a vector file (GeoJSON) with style file directly into a map is OK. Adding a vector file (GeoJSON) with style file while also publishing the layer into Layman results into a layer without styling.

Describe the solution you'd like
Also load layer's styles from the Layman.

Describe alternatives you've considered
none

Additional context
spin-off from #3440
related to #3579

@jmacura jmacura added the LayerSources Issues related to Layman, Micka, WMS, WFS, etc. label Nov 4, 2022
@jmacura jmacura added this to the 10.1 milestone Nov 4, 2022
@jmacura jmacura self-assigned this Nov 4, 2022
@raitisbe
Copy link
Collaborator

raitisbe commented Dec 5, 2022

@jmacura what is the style definition for that layer in layman in this case? Is it empty or could it be in SLD 1.1 format maybe?

@jmacura jmacura modified the milestones: 10.1, 11.0 Dec 7, 2022
@jmacura
Copy link
Collaborator Author

jmacura commented Dec 7, 2022

@raitisbe I have tested now with SLD 1.0 and the styles were loaded indeed... 🤔
image
cf. https://hub.lesprojekt.cz/rest/workspaces/macurajan/layers/zones

So, yes, the issue might be related to SLD 1.1 or QML.
@fzadrazil Do you have any specific use case when the style upload fails, which you could share with us?

@raitisbe
Copy link
Collaborator

raitisbe commented Dec 8, 2022

@jmacura Please check if #3616 solves it

@jmacura
Copy link
Collaborator Author

jmacura commented Jan 13, 2023

Problem is with QML styles.

@jmacura jmacura modified the milestones: 11.0, 11.1 Jan 19, 2023
@jmacura jmacura changed the title Vector layer added via Layman is not styled Support QML styles (Vector layer added via Layman is not styled) Mar 1, 2023
@jmacura
Copy link
Collaborator Author

jmacura commented Mar 8, 2023

We already support QML styles (cf. #3435). Seems like the QML file structure has changed recently and it is not yet reflected by geostyler-qgis-parser.

@FilipLeitner
Copy link
Collaborator

Update: geostyler/geostyler-qgis-parser#569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement LayerSources Issues related to Layman, Micka, WMS, WFS, etc.
Projects
None yet
Development

No branches or pull requests

4 participants