Fix for dev waldo

hadley · hriebl · commit 348db736157d · 2024-10-31T15:18:02.000+01:00
waldo now checks that ignore_attr is either TRUE, FALSE, or a character vector, so I made the minimal changes to your code to make this true.
diff --git a/R/testthat-helpers.R b/R/testthat-helpers.R
@@ -1,5 +1,5 @@
 all_attr_but_dim <- function(object, expected) {
-  ignore_attr <- names(attributes(object))
+  ignore_attr <- as.character(names(attributes(object)))
   ignore_attr <- c(ignore_attr, names(attributes(expected)))
   ignore_attr[ignore_attr != "dim"]
 }
@@ -38,6 +38,8 @@ expect_roughly <- function(object,
                            expected.label = NULL) {
   if (is.null(ignore_attr)) {
     ignore_attr <- all_attr_but_dim(object, expected)
+  } else {
+    ignore_attr <- FALSE
   }
 
   testthat::expect_equal(

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`all_attr_but_dim <- function(object, expected) {`
`2`		`- ignore_attr <- names(attributes(object))`
	`2`	`+ ignore_attr <- as.character(names(attributes(object)))`
`3`	`3`	`ignore_attr <- c(ignore_attr, names(attributes(expected)))`
`4`	`4`	`ignore_attr[ignore_attr != "dim"]`
`5`	`5`	`}`
`@@ -38,6 +38,8 @@ expect_roughly <- function(object,`
`38`	`38`	`expected.label = NULL) {`
`39`	`39`	`if (is.null(ignore_attr)) {`
`40`	`40`	`ignore_attr <- all_attr_but_dim(object, expected)`
	`41`	`+ } else {`
	`42`	`+ ignore_attr <- FALSE`
`41`	`43`	`}`
`42`	`44`
`43`	`45`	`testthat::expect_equal(`