[Bug] New accounts created without email adresses

[DerLeole]

Read the FAQ first!

Describe the bug

When creating new accounts using the admin interface, the email information isn't saved on account creation, resulting in various downstream bugs, like the inability to send welcome emails.

To Reproduce

Create a new account with an email.

Logs

kl_jellyfish_jfago  | [ERROR] 19:26:30 users.go:118: Failed to apply policy template for Jellyfin user "a71f88b795e347ce9ce7448f5efd99f6": No (valid) policy was given.
kl_jellyfish_jfago  | [ERROR] 19:26:30 users.go:125: Failed to apply configuration template for Jellyfin user "a71f88b795e347ce9ce7448f5efd99f6": 400 Unauthorized, check credentials.

Configuration

Not really, everything is setup as usual, no smtp, no email requirement, email sending disabled.

Platform/Version
Docker/Linux

Version git

Commit 11eb907

Build Time 2024-10-11 17:16:36 +0200 CEST

Built By "???"

Build Tags [e2ee external]

[DerLeole]

Addendum: This only happens when creating a new user with an email from the admin panel's account page. It also seems like the logs are irrelevant here.

This bug was introduced in 54e4a51 and is caused by the function to create users by admin not storing the email at all.

Fix: Either refactor more to reuse the PostInviteUserCreation function in the admin one, or duplicate the email creation code.

[hrfee]

Thanks for doing my job for me, I'll fix this as soon as I can (probably tomorrow). Sorry for only replying now too.

…

-------- Original Message --------

On 04/11/2024 13:23, Leo Keil wrote: Addendum: This only happens when creating a new user with an email from the admin panel's account page. This bug was introduced in [54e4a51](54e4a51) and is caused by the function to create users by admin not storing the email at all. Fix: Either refactor more to reuse the PostInviteUserCreation function in the admin one, or duplicate the email creation code. — Reply to this email directly, [view it on GitHub](#374 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AC27APN7AKN345R2JFIBDM3Z65YL7AVCNFSM6AAAAABQ4YUI4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUG4YDKOBVGU). You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[DerLeole]

No problem, I know the struggle haha.

Thanks for fixing and maintaining. If you for any reason can't get to it, I can also try my hand at a PR.

[hrfee]

that should do it, sorry it took this long to write a couple lines.

[DerLeole]

Awesome thank you! This is automatically pushed to unstable right?

I'll check it out tomorrow and close the issue!

[DerLeole]

I tested it and am sorry to report that there still seems to be some kind of problem, potentially only with the frontend.

• When creating a new account through the admin interface, there is no longer an error, but the email is still not shown in the admin list.
• Furthermore, while technically not part of this issue, certain subsequent actions triggered by account creation, some relying on email, are not triggered when creating an account from the admin panel still.
  • Jellyseerr users are not imported after admin account creation. This leads to a runaway issue, where you can't even change the email of an admin created account without error, as jfa-go assumes the account must be present in jellyseerr, thus attempting to change it there, but without the initial import failing to do so.
  • Possibly more, but I haven't tried it yet with other integrations

If you want I can create an issue for the other bug as well to track it better.

Thanks again for putting in the time to work on this! I quite like this project and would hope to work on this issue (and similar ones) sometime in december when my timeframe frees up :)

[Mavyre]

It might be related, but my users end up on a 500 Internal Server Error when clicking the email validation link.
I get that in the logs:

[ERROR] 15:48:50 users.go:125: �Failed to apply configuration template for Jellyfin user "f7e56080058a483292f6b65606d54db6": 400 Unauthorized, check credentials.

If it isn't, let me know if I need to open a new issue.

Edit: After really checking the logs, it looks like it's another issue. Opened #375