Update ESLint config with more strict TS rules

Author: ai

api/http/utils.ts

@@ -45,7 +45,7 @@ export async function fetchJSON<Response = unknown>(
     throw new Error(await response.text())
   }
   if (opts.response) opts.response(response)
-  return response.json()
+  return response.json() as Response
 }
 
 export interface Endpoint<

core/download.ts

@@ -5,7 +5,7 @@ export interface TextResponse {
   readonly contentType: string
   readonly headers: Headers
   readonly ok: boolean
-  parseJson(): null | unknown
+  parseJson(): unknown
   parseXml(): Document | null | XMLDocument
   readonly redirected: boolean
   readonly status: number
@@ -67,7 +67,7 @@ export function createTextResponse(
       }
 
       try {
-        return JSON.parse(text)
+        return JSON.parse(text) as unknown
       } catch (e) {
         if (e instanceof SyntaxError) {
           warning('Parse JSON error', e.message)

core/environment.ts

@@ -141,6 +141,6 @@ export function getTestEnvironment(): EnvironmentAndStore {
     persistentEvents: { addEventListener() {}, removeEventListener() {} },
     persistentStore: {},
     restartApp: () => {},
-    translationLoader: async () => ({})
+    translationLoader: () => Promise.resolve({})
   }
 }

core/export.ts

@@ -91,18 +91,23 @@ export function getOPMLBlob(): Blob {
   return new Blob([opml], { type: 'application/xml' })
 }
 
-export async function getInternalBlob(isIncludePosts: Boolean): Promise<Blob> {
+export type InternalExport = {
+  data: [CategoryValue, FeedWithPosts[]][]
+  type: 'feedsByCategory'
+}
+
+export async function getInternalBlob(isIncludePosts: boolean): Promise<Blob> {
   $exporting.set(true)
   let posts: PostValue[]
-  /* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition */
+
   if (isIncludePosts) {
     posts = await loadValue(getPosts()).then(value => value.list)
   }
   let enrichedData = $exportingFeedsByCategory
     .get()
     .map(([category, feeds]: [CategoryValue, FeedWithPosts[]]) => {
       let categoryTitle = getCategoryTitle(category)
-      /* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition */
+
       if (isIncludePosts) {
         feeds.forEach(feed => {
           feed.posts = posts.filter(post => post.feedId === feed.id)

core/import.ts

@@ -6,11 +6,12 @@ import {
   type CategoryValue,
   type FeedsByCategory
 } from './category.ts'
+import type { InternalExport } from './export.ts'
 import { addFeed, type FeedValue } from './feed.ts'
 import { readonlyExport } from './lib/stores.ts'
+import { unique } from './loader/utils.ts'
 import { importMessages } from './messages/index.ts'
 import { createFeedFromUrl } from './preview.ts'
-import { unique } from './loader/utils.ts'
 
 let $importedFeedsByCategory = atom<FeedsByCategory>([])
 export const importedFeedsByCategory = readonlyExport($importedFeedsByCategory)
@@ -139,6 +140,17 @@ export const toggleImportedFeed = (
   $importedFeeds.set(Array.from(selectedFeeds))
 }
 
+function isInternalExport(json: unknown): json is InternalExport {
+  return (
+    typeof json === 'object' &&
+    json !== null &&
+    'type' in json &&
+    json.type === 'feedsByCategory' &&
+    'data' in json &&
+    Array.isArray(json.data)
+  )
+}
+
 export const handleImportFile = (file: File): Promise<void> => {
   return new Promise(resolve => {
     $reading.set(true)
@@ -155,7 +167,7 @@ export const handleImportFile = (file: File): Promise<void> => {
       if (fileExtension === 'json') {
         try {
           let jsonData = JSON.parse(content)
-          if (jsonData.type === 'feedsByCategory') {
+          if (isInternalExport(jsonData)) {
             $importedFeedsByCategory.set(jsonData.data)
             importSubscribe()
             selectAllImportedFeeds()

core/lib/stores.ts

@@ -33,14 +33,17 @@ export function increaseKey<Store extends MapStore>(
   store: Store,
   key: NumberKeys<StoreValue<Store>>
 ): void {
-  store.setKey(key, store.get()[key] + 1)
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+  let value = store.get()[key] as number
+  store.setKey(key, value + 1)
 }
 
 export function listenMany<SourceStores extends ReadableAtom[]>(
   stores: [...SourceStores],
   cb: (...values: StoreValues<SourceStores>) => void
 ): () => void {
   function listener(): void {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return
     let values = stores.map(store => store.get()) as StoreValues<SourceStores>
     cb(...values)
   }

core/loader/json-feed.ts

@@ -73,7 +73,7 @@ function isObject(value: unknown): value is Record<string, unknown> {
 }
 
 function stringify(value: unknown): string {
-  return typeof value === 'object' ? JSON.stringify(value) : `${value}`
+  return typeof value === 'object' ? JSON.stringify(value) : String(value)
 }
 
 function validate<ValidatedType>(

core/preview.ts

@@ -288,7 +288,7 @@ export const onPreviewUrlType = debounce((value: string) => {
   }
 }, 500)
 
-export async function setPreviewCandidate(url: string): Promise<void> {
+export function setPreviewCandidate(url: string): void {
   let candidate = $candidates.get().find(i => i.url === url)
   if (candidate) {
     $candidate.set(url)

core/request.ts

@@ -80,7 +80,7 @@ export function expectRequest(url: string): RequestMock {
       expect.response = body
     },
     andWait() {
-      let resolveWait: Function
+      let resolveWait: () => void
       expect.wait = new Promise(resolve => {
         resolveWait = resolve
       })

core/test/dom-parser.ts

@@ -1,7 +1,7 @@
 import { JSDOM } from 'jsdom'
 
 let window = new JSDOM().window
-// @ts-expect-error
+// @ts-expect-error JSDOM types are incomplete
 global.window = window
 global.DOMParser = window.DOMParser
 global.File = window.File