Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated request package #2238

Open
strmer15 opened this issue Feb 14, 2023 · 0 comments · May be fixed by #2239
Open

Remove deprecated request package #2238

strmer15 opened this issue Feb 14, 2023 · 0 comments · May be fixed by #2239

Comments

@strmer15
Copy link

Are you sure this is an issue with the Botkit core module?

In several of the botkit adapters, there are imports for the request package - it's been deprecated for a few years now.

What are you trying to achieve or the steps to reproduce?

The request library should be replaced with a package that is maintained. For Node.js 18+, there's a native fetch that can be used, but for other use cases the node-fetch library is great (or cross-fetch for isomorphic uses). Plus, switching to it makes it easier in the future to switch to the native Node / browser fetch API.

@strmer15 strmer15 linked a pull request Feb 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant