Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not scrolling on android #734

Open
stereodenis opened this issue Dec 15, 2023 · 8 comments
Open

Not scrolling on android #734

stereodenis opened this issue Dec 15, 2023 · 8 comments

Comments

@stereodenis
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-dropdown-picker/src/components/Picker.js b/node_modules/react-native-dropdown-picker/src/components/Picker.js
index e3fb93b..12eb5ed 100644
--- a/node_modules/react-native-dropdown-picker/src/components/Picker.js
+++ b/node_modules/react-native-dropdown-picker/src/components/Picker.js
@@ -14,16 +14,15 @@ import {
     TouchableOpacity,
     Text,
     Image,
-    FlatList,
     TextInput,
     Dimensions,
-    ScrollView,
     Modal,
     ActivityIndicator,
     BackHandler,
     Platform,
     StyleSheet,
 } from 'react-native';
+import { FlatList, ScrollView } from 'react-native-gesture-handler';
 
 const { height: WINDOW_HEIGHT } = Dimensions.get('window');
 

This issue body was partially generated by patch-package.

@YASH6004
Copy link

I made the changes but it threw this error
Screenshot 2024-01-30 at 12 15 32 PM

@themad1706
Copy link

Thx @stereodenis , I just had the same issue 👍

@YASH6004 You probably need to install it https://github.com/software-mansion/react-native-gesture-handler

@mark-quinn
Copy link

@hossein-zare I have found an issue with Android too. I noticed the component has been updated here but in the node_modules the Picker.js file does not have the imports coming from react-native-gesture-handler.

Any idea why the version that is installed into the node modules is different?

@SamuelWallisBauer
Copy link

+1

@MussadiqAli
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-dropdown-picker/src/components/Picker.js b/node_modules/react-native-dropdown-picker/src/components/Picker.js
index e3fb93b..12eb5ed 100644
--- a/node_modules/react-native-dropdown-picker/src/components/Picker.js
+++ b/node_modules/react-native-dropdown-picker/src/components/Picker.js
@@ -14,16 +14,15 @@ import {
     TouchableOpacity,
     Text,
     Image,
-    FlatList,
     TextInput,
     Dimensions,
-    ScrollView,
     Modal,
     ActivityIndicator,
     BackHandler,
     Platform,
     StyleSheet,
 } from 'react-native';
+import { FlatList, ScrollView } from 'react-native-gesture-handler';
 
 const { height: WINDOW_HEIGHT } = Dimensions.get('window');
 

This issue body was partially generated by patch-package.
applied the same solution but scroll still not working in android.

@rgomezp
Copy link

rgomezp commented Jul 15, 2024

How is this still open?

@SamuelWallisBauer
Copy link

No PRs merged since October is how

@ChromeQ
Copy link

ChromeQ commented Sep 11, 2024

@hossein-zare I have found an issue with Android too. I noticed the component has been updated here but in the node_modules the Picker.js file does not have the imports coming from react-native-gesture-handler.

Any idea why the version that is installed into the node modules is different?

That link goes to the dev-5.x branch, if you change the branch in the top left to the tag version v5.4.6 you will see that it still imports FlatList and ScrollView from react-native rather than react-native-gesture-handler.

Solution is to either use patch-package as described above or add the branch name to your package.json - instructions here: https://stackoverflow.com/questions/39732397/install-specific-branch-from-github-using-npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants