Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching Improvements #21

Open
horahoradev opened this issue May 8, 2022 · 1 comment
Open

Caching Improvements #21

horahoradev opened this issue May 8, 2022 · 1 comment

Comments

@horahoradev
Copy link
Owner

As it is, Horahora isn't very cache friendly. The correct response content of most GET requests depends on the user's JWT, and more specifically on their permissions. If the user is unprivileged, they MUST only see unapproved videos. If the user is privileged, then they can receive everything.
It would be nice if we had a strategy in place that would enable us to share cache items between users, instead of having the cache keyed on the JWT.
@GabenGar
Copy link
Contributor

This could be solved by having a clear separation between public pages/endpoints and protected ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@horahoradev @GabenGar