Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): rest and graphql pages not being rendered when french is selected as app language #4004

Merged
merged 3 commits into from Apr 25, 2024
Merged

fix(common): rest and graphql pages not being rendered when french is selected as app language #4004

merged 3 commits into from Apr 25, 2024

Conversation

JoelJacobStephen
Copy link
Contributor

Ticket

Description

This PR fixes the issue where selecting French as the app language breaks the REST and GraphQL pages of the app.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@JoelJacobStephen JoelJacobStephen added the bug fix This fixes a bug label Apr 24, 2024
@JoelJacobStephen JoelJacobStephen changed the title fix: rest and graphql pages not being rendered when french is selected as app language fix(common): rest and graphql pages not being rendered when french is selected as app language Apr 24, 2024
nivedin
nivedin previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@AndrewBastin AndrewBastin changed the base branch from main to release/2024.3.2 April 25, 2024 12:24
@AndrewBastin AndrewBastin merged commit c2c4e62 into hoppscotch:release/2024.3.2 Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeriaux fmeriaux fmeriaux left review comments

@nivedin nivedin nivedin left review comments

@liyasthomas liyasthomas Awaiting requested review from liyasthomas

@amk-dev amk-dev Awaiting requested review from amk-dev amk-dev is a code owner

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin AndrewBastin is a code owner

Assignees
No one assigned
Labels
bug fix This fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Hoppscotch doesn't load in French since last version
4 participants
@JoelJacobStephen @fmeriaux @nivedin @AndrewBastin