-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class based Component and PureComponent to improve compatibility with React #2928
Comments
|
Hi @usualoma I agree for the legacy part but some libraries need Component to be implemented. I am talking about Framer in my case. Do we want Hono to support popular libraries, if yes, I would say we can merge it, if No then I would say Hono should be used only for simple use case. |
Hi @gaetan-puleo |
Hi @yusukebe In terms of implementation feasibility, I think it could be done with an approach like #2933. However, looking at the way "hono" and "honox" are currently used, I think that users who need "React" often use "React" directly, not "hono/jsx/dom". I am wondering if it makes sense to support legacy APIs in "hono/jsx/dom". I know there are users who have high expectations of "hono/jsx/dom" and I think it would be an interesting challenge to move forward with #2933, but I don't think the maintenance costs are small. What are your views on this? |
In my opinion, we don't have to support the legacy APIs in Nevertheless, it is very interesting to see React libraries running in hono/jsx. It is not really possible to implement all of them, so for now, if we are going to draw a line, it is better not to implement the legacy APIs. We will need to think about new features for React 19 in the future. |
@gaetan-puleo @yusukebe Thank you! So, let's make it a policy not to add support for the I'll leave #2933 (which I implemented a little extra after the first comment, so it's almost ready to work) as a POC. If the opinion changes in the future to support it, we'll use it then. |
What is the feature you are proposing?
I tried to use https://magicui.design/ with https://www.framer.com/motion/, it was not possible to use because Component is not exported.
I don't know what it takes to make it possible.
I would like to use this effect from Magicui.
https://magicui.design/docs/components/animated-beam
The text was updated successfully, but these errors were encountered: