From cb2453fd6dc95cdcf7d5037438bad601019cfd90 Mon Sep 17 00:00:00 2001 From: "Glenn Vandeuren (aka Iondependent)" Date: Wed, 25 Dec 2024 15:26:08 +0100 Subject: [PATCH 1/2] Add quality scale --- .../niko_home_control/quality_scale.yaml | 41 +++++++++++++++++++ script/hassfest/quality_scale.py | 1 - 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 homeassistant/components/niko_home_control/quality_scale.yaml diff --git a/homeassistant/components/niko_home_control/quality_scale.yaml b/homeassistant/components/niko_home_control/quality_scale.yaml new file mode 100644 index 0000000000000..d630144ed3739 --- /dev/null +++ b/homeassistant/components/niko_home_control/quality_scale.yaml @@ -0,0 +1,41 @@ +rules: + # Bronze + brands: done + common-modules: done + config-flow-test-coverage: done + config-flow: done + dependency-transparency: done + docs-installation-instructions: done + entity-unique-id: done + has-entity-name: done + runtime-data: done + test-before-configure: done + test-before-setup: done + unique-config-entry: done + + # Silver + config-entry-unloading: done + entity-unavailable: todo + integration-owner: done + log-when-unavailable: todo + test-coverage: todo + + # Gold + devices: done + discovery: todo + docs-supported-devices: todo + docs-troubleshooting: todo + docs-use-cases: todo + dynamic-devices: todo + entity-category: todo + entity-device-class: todo + entity-translations: todo + exception-translations: done + icon-translations: todo + reconfiguration-flow: todo + repair-issues: done + stale-devices: todo + + # Platinum + async-dependency: done + strict-typing: todo diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py index 3d880d7b53685..5dc620ce86d7e 100644 --- a/script/hassfest/quality_scale.py +++ b/script/hassfest/quality_scale.py @@ -712,7 +712,6 @@ class Rule: "nibe_heatpump", "nice_go", "nightscout", - "niko_home_control", "nilu", "nina", "nissan_leaf", From 04f8b563e6ccfa01b55dc10ca477dc65f606a321 Mon Sep 17 00:00:00 2001 From: "Glenn Vandeuren (aka Iondependent)" Date: Sun, 5 Jan 2025 21:26:28 +0100 Subject: [PATCH 2/2] Update quality_scale.yaml --- .../niko_home_control/quality_scale.yaml | 56 +++++++++++++++++-- 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/niko_home_control/quality_scale.yaml b/homeassistant/components/niko_home_control/quality_scale.yaml index d630144ed3739..49304cbbf0ea2 100644 --- a/homeassistant/components/niko_home_control/quality_scale.yaml +++ b/homeassistant/components/niko_home_control/quality_scale.yaml @@ -1,11 +1,29 @@ rules: # Bronze + action-setup: + status: exempt + comment: | + This integration does not provide additional actions. + appropriate-polling: + status: exempt + comment: | + This integration does not require polling (events baby!). brands: done common-modules: done config-flow-test-coverage: done config-flow: done dependency-transparency: done + docs-actions: + status: exempt + comment: | + This integration does not provide additional actions. + docs-high-level-description: todo docs-installation-instructions: done + docs-removal-instructions: todo + entity-event-setup: + status: exempt + comment: | + Entities of this integration does not explicitly subscribe to events. entity-unique-id: done has-entity-name: done runtime-data: done @@ -14,23 +32,47 @@ rules: unique-config-entry: done # Silver + action-exceptions: + status: exempt + comment: | + This integration does not provide additional actions. config-entry-unloading: done + docs-configuration-parameters: + status: exempt + comment: No options to configure + docs-installation-parameters: + status: exempt + comment: No options to configure entity-unavailable: todo integration-owner: done log-when-unavailable: todo + parallel-updates: todo + reauthentication-flow: + status: exempt + comment: | + This integration does not require authentication. test-coverage: todo - # Gold devices: done + diagnostics: + status: exempt + comment: | + This integration does not have any diagnostics. + discovery-update-info: todo discovery: todo + docs-data-update: todo + docs-examples: todo + docs-known-limitations: todo docs-supported-devices: todo + docs-supported-functions: todo docs-troubleshooting: todo docs-use-cases: todo - dynamic-devices: todo - entity-category: todo - entity-device-class: todo + dynamic-devices: done + entity-category: done + entity-device-class: done + entity-disabled-by-default: todo entity-translations: todo - exception-translations: done + exception-translations: todo icon-translations: todo reconfiguration-flow: todo repair-issues: done @@ -38,4 +80,8 @@ rules: # Platinum async-dependency: done + inject-websession: + status: exempt + comment: | + This integration does not require a websession. strict-typing: todo