Jewish Calendar Holiday sensor is broken.

[theberko]

The problem

Holiday sensor shows "unknown".

What version of Home Assistant Core has the issue?

Version core-2024.12.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

jewish-calendar

Link to integration documentation on our website

https://www.home-assistant.io/integrations/jewish_calendar

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.helpers.entity
Source: helpers/entity.py:960
First occurred: December 23, 2024 at 7:58:49 AM (8773 occurrences)
Last logged: 9:05:21 AM

Update for sensor.jewish_calendar_holiday fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 960, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1318, in async_device_update
    await self.async_update()
  File "/usr/src/homeassistant/homeassistant/components/jewish_calendar/sensor.py", line 234, in async_update
    self._attr_native_value = self.get_state(
                              ~~~~~~~~~~~~~~^
        daytime_date, after_shkia_date, after_tzais_date
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/src/homeassistant/homeassistant/components/jewish_calendar/sensor.py", line 289, in get_state
    self._attr_options = htables.get_all_holidays(self._language)
                         ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'hdate.htables' has no attribute 'get_all_holidays'

Additional information

No response

[home-assistant]

Hey there @tsvi, mind taking a look at this issue as it has been labeled with an integration (jewish_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jewish_calendar can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign jewish_calendar Removes the current integration label and assignees on the issue, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

jewish_calendar documentation
jewish_calendar source
_{^{(message by IssueLinks)}}

[tsvi]

Did this happen after upgrading? Did you try restarting HomeAssistant?
2024.12+ should have this function. (Using libhdate 0.11.1)

[theberko]

Worked in 2024.11, broke with 2024.12. Tried restart, did not help.

[theberko]

Just tried Safe Mode and it works there. So it must be a custom component that is causing it to fail.

[tsvi]

Sounds like something is blocking the upgrade of the hdate library which was updated in 2024.12.
Could be a custom component blocking the installation of dependencies. In any case, glad you figured it out.