Add-on Dnsmasq fails to start after update to 1.8.0 #3609
Comments
|
Same issue on my side. Reverted back to previous version. |
|
looks like the newly introduced option should be named cache-size= instead of cache= in file dnsmasq/rootfs/usr/share/tempio/dnsmasq.config (line 12)... |
|
Do we not even just spin up these add-ons once as part of our testing process? |
|
This issue seems bad because it seems like there is zero testing before pushing out to production. I created a new config from the documentation and also hit this error. Maybe this is something that can be improved for future releases. |
The new cache feature seems to use the wrong value in its config so we fix it. fixes home-assistant#3609 Signed-off-by: Philipp Rossak <[email protected]>
|
Hello. Is the problem fixed? Can someone please explain the solution? Thank you. |
|
Yes, seems fixed. Just update to latest version. |
|
Thank you. Sorry, I can't.. : 'AddonManager.install' blocked from execution, no host internet connection |
I had the same issues, after I updated to version 1.8.0 since my network relies on the dnsmasq service. I basically reconfigured my network to not use dnsmasq as dns server and rebooted my homeassistant server (disconnect and reconnect the ethernet port should be also sufficient). Now an update to version 1.8.1 should be possible. |
|
Sorry everyone, this is completely my fault. While it would be nice to have a way to catch errors like this in CI before add-ons are pushed to production (which happens automatically on PR merge), I believe it wouldn't happen if someone else were reviewing the PR. I missed the wrong config entry name in the config and as I thought it's in overall a simple change, I just carelessly merged it. Next time I will make sure to test every change before merging add-on PRs. |
|
No worries! We appreciate all the hard work you put in. Mistakes happen, and it's all part of the learning process.
Your dedication and commitment are valued. Thank you for taking responsibility and for your continued efforts.
Keep up the great work!
From: Jan Čermák ***@***.***>
Sent: maandag 27 mei 2024 17:09
To: home-assistant/addons ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [home-assistant/addons] Add-on Dnsmasq fails to start after update to 1.8.0 (Issue #3609)
Sorry everyone, this is completely my fault. While it would be nice to have a way to catch errors like this in CI before add-ons are pushed to production (which happens automatically on PR merge), I believe it wouldn't happen if someone else were reviewing the PR. I missed the wrong config entry name in the config and as I thought it's in overall a simple change, I just carelessly merged it. Next time I will make sure to test every change before merging add-on PRs.
-
Reply to this email directly, view it on GitHub<#3609 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJVYLQV5MSAKRAFSXSYBBX3ZENEB3BFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVA4DKNBTGU4DIMMCUR2HS4DFUVUXG43VMWSXMYLMOVS2UMRTGE2TINBZGUYTNJ3UOJUWOZ3FOKTGG4TFMF2GK>.
You are receiving this email because you authored the thread.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Yeah absolutely no blame on anyone in particular. These things happen, so we should at least have some kind of sanity check testing as part of CI. |
Describe the issue you are experiencing
after update from 1.7.0 to 1.8.0 i got this error. Restoring backup to 1.7.0 makes it working again.
dnsmasq: bad option at line 10 of /etc/dnsmasq.conf
[13:25:45] WARNING: Halt add-on
s6-rc: info: service legacy-services successfully started
s6-rc: info: service legacy-services: stopping
[13:25:46] INFO: Service restart after closing
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped
What type of installation are you running?
Home Assistant OS
Which operating system are you running on?
Home Assistant Operating System
Which add-on are you reporting an issue with?
Dnsmasq
What is the version of the add-on?
1.8.0
Steps to reproduce the issue
after update from 1.7.0 to 1.8.0 i got this error
System Health information
N/A
Anything in the Supervisor logs that might be useful for us?
Anything in the add-on logs that might be useful for us?
Additional information
n/a
The text was updated successfully, but these errors were encountered: