Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allow specifying rev/tag/branch for templates #122

Open
matthme opened this issue Sep 20, 2023 · 1 comment
Open

[Enhancement] Allow specifying rev/tag/branch for templates #122

matthme opened this issue Sep 20, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@matthme
Copy link
Collaborator

matthme commented Sep 20, 2023

The degit crate used to fetch the template when using the --templates-url argument does not allow to specify rev/tag/branch which is quite a bummer when a template is supposed to support multiple holochain versions.

@c12i
Copy link
Collaborator

c12i commented Jan 5, 2024

I think it probably has to do with degit not supporting this, and the project seems to not have been updated in three years.

To support specifying the /rev/tag/branch, we could probably migrate to using the git2 crate and cloning the repo using the RepoBuilder, then manually degit the cloned repo by deleting the .git directory.

@c12i c12i added the enhancement New feature or request label Jan 19, 2024
@c12i c12i self-assigned this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants