Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependancy Issue #17

Open
smfaizalkhan opened this issue Oct 16, 2024 · 2 comments
Open

Dependancy Issue #17

smfaizalkhan opened this issue Oct 16, 2024 · 2 comments

Comments

@smfaizalkhan
Copy link

smfaizalkhan commented Oct 16, 2024

Hi @hoangtien2k3 @hoangchungk53qx1
The repo is really great and good and i would like to contribute as well,But i couldnt do an initial setUp

when i run the mvn clean install i see a quite a few dependancy conflicts especially the spring-web and boot version

Here it uses 2.7.16
org.springframework.boot
spring-boot-starter-parent
2.7.16

but the web version

org.springframework spring-web 6.1.11
    and in most of the modules spring-web  uses the spring base version which is supposed to be 5.x series
    
    <dependency>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-webflux</artifactId>
		</dependency>
		
		Even excluding it 
		
		<dependency>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-webflux</artifactId>
		<exclusions>
			<exclusion>
				<groupId>org.springframework</groupId>
				<artifactId>spring-web</artifactId>
			</exclusion>
		</exclusions>
	</dependency>
	
	dosent fix the issue
@hoangtien2k3
Copy link
Owner

Hi @smfaizalkhan

Thanks for the kind words! It looks like there are some dependency version mismatches causing issues with your setup. The project is using Spring Boot 2.7.16, but Spring Web version 6.1.11, which is part of Spring Framework 6.x series, might not be compatible with the 2.x Spring Boot version.

To resolve this, you could try aligning both Spring Boot and Spring Web versions. Either downgrade spring-web to a version compatible with 2.7.16 or upgrade the Spring Boot version to 3.x, which supports Spring Framework 6.x.

Let me know if you need further assistance!

@hoangtien2k3
Copy link
Owner

@smfaizalkhan

Contributing

Thank you for considering contributing to our project! Follow these steps to set up the project and resolve common issues before making contributions:

1. Resolve Spring Dependency Conflicts

The project uses Spring Boot 2.7.16, which is compatible with Spring Framework 5.x. If you encounter dependency conflicts like seeing spring-web 6.1.11 (from Spring Framework 6.x), here’s how to resolve it:

  • Option 1: Downgrade spring-web to a version compatible with Spring Boot 2.7.16, such as 5.3.x.
  • Option 2: Alternatively, you can upgrade the project to Spring Boot 3.x, which is compatible with Spring Framework 6.x. Note that this will require additional refactoring to handle breaking changes.

2. Fork the Repository

  • Fork the repository to your own GitHub account to make changes safely.
  • Clone the forked repository to your local machine using:
  git clone https://github.com/your-username/repo-name.git

3. Set Up the Project Locally

  • After cloning, navigate to the project directory and ensure all dependencies are properly installed by running:
mvn clean install

4. Create a Branch for Your Changes

  • Always create a new branch for the feature or fix you want to contribute:
git checkout -b fix-version-conflict

5. Make the Necessary Adjustments

  • Resolve any dependency conflicts, make your changes, and test your setup.
  • Run tests to ensure everything is working correctly:
mvn test

6. Submit a Pull Request

  • Push your branch to your forked repository:
git push origin fix-version-conflict

If you need help at any step or have questions, feel free to reach out! We're happy to assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants