[#462] fix for fiat amount parsing on Yosemite

Author: mackuba

Hive.xcodeproj/project.pbxproj

@@ -223,6 +223,7 @@
 		58AE8CBB19226AF900946C97 /* icon-success.png in Resources */ = {isa = PBXBuildFile; fileRef = 58AE8CB919226AF800946C97 /* icon-success.png */; };
 		58AE8CBC19226AF900946C97 /* icon-success@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = 58AE8CBA19226AF800946C97 /* icon-success@2x.png */; };
 		58AE8CC9192CCF1200946C97 /* HIGeneralPreferencesViewController.strings in Resources */ = {isa = PBXBuildFile; fileRef = 58AE8CCB192CCF1200946C97 /* HIGeneralPreferencesViewController.strings */; };
+		58B83ABE1A60B5BF00A9172D /* NSDecimalNumberSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = 58B83ABD1A60B5BF00A9172D /* NSDecimalNumberSpec.m */; };
 		58C4E84719B0BD53003B5171 /* HITransactionPopoverViewController.xib in Resources */ = {isa = PBXBuildFile; fileRef = 58C4E84919B0BD53003B5171 /* HITransactionPopoverViewController.xib */; };
 		58C4E86819B0BDD3003B5171 /* HITransactionPopoverViewController.strings in Resources */ = {isa = PBXBuildFile; fileRef = 58C4E86A19B0BDD3003B5171 /* HITransactionPopoverViewController.strings */; };
 		58C85B5818FFE90700B2C350 /* HISignMessageWindowController.xib in Resources */ = {isa = PBXBuildFile; fileRef = 58C85B5A18FFE90700B2C350 /* HISignMessageWindowController.xib */; };
@@ -1856,6 +1857,7 @@
 		58AE8CE3192CCF2C00946C97 /* pt */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = pt; path = pt.lproj/HIGeneralPreferencesViewController.strings; sourceTree = "<group>"; };
 		58AE8CE4192CCF2D00946C97 /* ro */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ro; path = ro.lproj/HIGeneralPreferencesViewController.strings; sourceTree = "<group>"; };
 		58AE8CE5192CCF2D00946C97 /* hu */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = hu; path = hu.lproj/HIGeneralPreferencesViewController.strings; sourceTree = "<group>"; };
+		58B83ABD1A60B5BF00A9172D /* NSDecimalNumberSpec.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NSDecimalNumberSpec.m; sourceTree = "<group>"; };
 		58C4E84819B0BD53003B5171 /* en */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = en; path = en.lproj/HITransactionPopoverViewController.xib; sourceTree = "<group>"; };
 		58C4E84A19B0BD5A003B5171 /* pl */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = pl; path = pl.lproj/HITransactionPopoverViewController.xib; sourceTree = "<group>"; };
 		58C4E84B19B0BD61003B5171 /* fr */ = {isa = PBXFileReference; lastKnownFileType = file.xib; name = fr; path = fr.lproj/HITransactionPopoverViewController.xib; sourceTree = "<group>"; };
@@ -2530,8 +2532,9 @@
 			isa = PBXGroup;
 			children = (
 				24EAAFC8186E1BBD00E1D2D3 /* HIBitcoinFormatServiceSpec.m */,
-				24EAAFC3186E1BBD00E1D2D3 /* Supporting Files */,
 				1AA107B12E9AB06FCF455005 /* HICurrencyFormatServiceSpec.m */,
+				58B83ABD1A60B5BF00A9172D /* NSDecimalNumberSpec.m */,
+				24EAAFC3186E1BBD00E1D2D3 /* Supporting Files */,
 			);
 			path = HiveTests;
 			sourceTree = "<group>";
@@ -3477,6 +3480,7 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				58B83ABE1A60B5BF00A9172D /* NSDecimalNumberSpec.m in Sources */,
 				24EAAFC9186E1BBD00E1D2D3 /* HIBitcoinFormatServiceSpec.m in Sources */,
 				1AA10DECEE3B99EDD1C14B81 /* HICurrencyFormatServiceSpec.m in Sources */,
 			);

Hive/Categories/NSDecimalNumber+HISatoshiConversion.m

@@ -1,15 +1,28 @@
 #import "NSDecimalNumber+HISatoshiConversion.h"
 
+static NSDecimalNumberHandler *_satoshiRoundingBehavior;
+
 @implementation NSDecimalNumber(HISatoshiConversion)
 
++ (void)load {
+    // workaround for a NSDecimalNumber bug in Yosemite
+    _satoshiRoundingBehavior = [NSDecimalNumberHandler decimalNumberHandlerWithRoundingMode:NSRoundPlain
+                                                                                      scale:0
+                                                                           raiseOnExactness:NO
+                                                                            raiseOnOverflow:NO
+                                                                           raiseOnUnderflow:NO
+                                                                        raiseOnDivideByZero:NO];
+}
+
 + (NSDecimalNumber *)hiDecimalNumberWithSatoshi:(satoshi_t)satoshi {
     return [NSDecimalNumber decimalNumberWithMantissa:ABS(satoshi)
                                              exponent:-8
                                            isNegative:satoshi < 0];
 }
 
 - (satoshi_t)hiSatoshi {
-    return [self decimalNumberByMultiplyingByPowerOf10:8].unsignedLongLongValue;
+    NSDecimalNumber *satoshiAmount = [self decimalNumberByMultiplyingByPowerOf10:8];
+    return [[satoshiAmount decimalNumberByRoundingAccordingToBehavior:_satoshiRoundingBehavior] unsignedLongLongValue];
 }
 
 @end

HiveTests/NSDecimalNumberSpec.m

@@ -0,0 +1,45 @@
+//
+//  NSDecimalNumberSpec.m
+//  Hive
+//
+//  Created by Jakub Suder on 10/01/15.
+//  Copyright (c) 2015 Hive Developers. All rights reserved.
+//
+
+#import "NSDecimalNumber+HISatoshiConversion.h"
+
+SPEC_BEGIN(NSDecimalNumberSpec)
+
+describe(@"hiSatoshi", ^{
+    it(@"should return the amount in satoshi", ^{
+        NSDecimalNumber *num = [NSDecimalNumber decimalNumberWithString:@"25"];
+
+        assertThatUnsignedLongLong([num hiSatoshi], is(equalToUnsignedLongLong(2500000000)));
+    });
+
+    context(@"for numbers with a fractional part", ^{
+        it(@"should return a correct value", ^{
+            NSDecimalNumber *num = [NSDecimalNumber decimalNumberWithString:@"6.251"];
+
+            assertThatUnsignedLongLong([num hiSatoshi], is(equalToUnsignedLongLong(625100000)));
+        });
+    });
+
+    context(@"for numbers with fractions of satoshi", ^{
+        it(@"should return a rounded value", ^{
+            NSDecimalNumber *num = [NSDecimalNumber decimalNumberWithString:@"11.234200989"];
+
+            assertThatUnsignedLongLong([num hiSatoshi], is(equalToUnsignedLongLong(1123420099)));
+        });
+    });
+
+    context(@"for numbers with a very long fractional part", ^{
+        it(@"should return a rounded value", ^{
+            NSDecimalNumber *num = [NSDecimalNumber decimalNumberWithString:@"3045.001122334455667788"];
+
+            assertThatUnsignedLongLong([num hiSatoshi], is(equalToUnsignedLongLong(304500112233)));
+        });
+    });
+});
+
+SPEC_END