Custom Prometheus metrics not showing

[CharlieC3]

It seems only the Prometheus metrics that come out of the box are displaying on the /metrics page, and none of the custom ones wired up here: https://github.com/hirosystems/signer-metrics-api/blob/main/src/api/routes/prom-metrics.ts

[zone117x]

@CharlieC3 I separated the signer related metrics so they could be public (compared to the default ones on the private prometheus port). They are exposed at https://api.hiro.so/signer-metrics/metrics

Does that work? I could also include these in the private endpoint if that's easier.

[CharlieC3]

Hmm I'm not sure we should be exposing Prometheus metrics on a public endpoint, it's a paradigm we haven't followed in other apps because it invites more scrapers (in addition to the ones we have now), and it doesn't use the standard prom port.

The reason why Hank exposed it for us was to get Hiros dashboards up and running sooner for helping in Nakamoto.

Do you have any preferences here?

[zone117x]

We can move it to the private endpoint 👍