Support: Clarinet Requirements to automatically add the Trait Dependencies

[BowTiedBlox]

Is your feature request related to a problem? Please describe.
When adding a smart contract that depends on a trait (e.g., impl-trait x), the required traits should be automatically included alongside other contract dependencies.

For example, in the smart contract SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-sbtc-bdc-v-1-2.clar, the following trait dependency is declared:

(impl-trait .xyk-staking-trait-v-1-2.xyk-staking-trait)

Currently, this trait is not added to the .cache/requirements folder and the simnet-plan automatically.

Describe the solution you'd like
When running clarinet requirements add <contract-name>, any referenced traits should also be included in the .cache and simnet-plan.

Example:

clarinet requirements add SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-sbtc-bdc-v-1-2.clar

Expected behavior: The associated traits should be added automatically.

Describe alternatives you've considered

• Currently, traits must be added manually, for example:

clarinet requirements add SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-trait-v-1-2

Additional context
Clarinet version used: 2.12.0
Might be related to #710 as the contract mentioned there, SPJ81C2WPQHFB6XTG518JKPABWM639R2X0B331XE.slimy-copper-walrus, uses traits as well.

[hugocaillard]

Hey @BowTiedBlox
What you describe is the expected behaviour (if you add SP3D6PV2ACBPEKYJTCMH7HEN02KP87QSP8KTEH335.megapont-ape-club-nft as a requirement, you'll see that the nft-trait and the commission traits are also added in .cache and deployment plan).
So there must be something we are not handling correctly with this particular contract or trait you mentions.
We'll investigate, thanks for the detailled issue

[hugocaillard]

Related to #1463

[hugocaillard]

Hello @BowTiedBlox
I tried to reproduce with the latestv version of Clarinet (2.15.1) and it seems to be working properly.

With just this requirement:

[[project.requirements]]
contract_id = 'SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-sbtc-bdc-v-1-2'

I do get all of the contract sub-dependencies:

> tree .cache                     
.cache
└── requirements
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.sip-010-trait-ft-standard-v-1-1.clar
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.sip-010-trait-ft-standard-v-1-1.json
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-pool-sbtc-bdc-v-1-1.clar
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-pool-sbtc-bdc-v-1-1.json
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-pool-trait-v-1-2.clar
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-pool-trait-v-1-2.json
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-sbtc-bdc-v-1-2.clar
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-sbtc-bdc-v-1-2.json
    ├── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-trait-v-1-2.clar
    └── SM1793C4R5PZ4NS4VQ4WMP7SKKYVH8JZEWSZ9HCCR.xyk-staking-trait-v-1-2.json

it's possible that you had a version that didn't properly epoch 3.1 contract back then.
Can you confirm that it works for you we Clarinet 2.15.1?