Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CLI support: clippy and fmt + rename commands #452

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

add CLI support: clippy and fmt + rename commands #452

wants to merge 20 commits into from

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Feb 28, 2025 •
edited
Loading

  • update commands to bitcoin-indexer from ordhook

  • outputs into the summary what has to be fixed and how to be fixed

  • fixes Clippy Support #451

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.88679% with 102 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...k-core/src/core/protocol/inscription_sequencing.rs 0.00% 21 Missing ⚠️
components/ordhook-core/src/utils/mod.rs 0.00% 15 Missing ⚠️
components/ordhook-core/src/service/mod.rs 0.00% 9 Missing ⚠️
components/config/src/toml.rs 0.00% 7 Missing ⚠️
components/runes/src/db/cache/index_cache.rs 0.00% 7 Missing ⚠️
components/chainhook-sdk/src/observer/zmq.rs 0.00% 5 Missing ⚠️
...c/core/pipeline/processors/inscription_indexing.rs 0.00% 5 Missing ⚠️
components/ordhook-core/src/db/blocks.rs 37.50% 5 Missing ⚠️
components/chainhook-sdk/src/utils/mod.rs 0.00% 4 Missing ⚠️
...k-core/src/core/meta_protocols/brc20/test_utils.rs 0.00% 4 Missing ⚠️
... and 14 more

📢 Thoughts on this report? Let us know!

@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 28, 2025 12:24 — with GitHub Actions Error
@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 28, 2025 13:03 — with GitHub Actions Error
@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 28, 2025 19:11 — with GitHub Actions Error
@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 28, 2025 19:23 — with GitHub Actions Error
@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 28, 2025 19:46 — with GitHub Actions Error
@ASuciuX ASuciuX had a problem deploying to Development-mainnet-blue February 28, 2025 20:45 — with GitHub Actions Error
@ASuciuX ASuciuX requested a review from rafaelcr March 3, 2025 13:39
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bitcoin-indexer ❌ Failed (Inspect) Mar 5, 2025 5:39pm

ASuciuX added 19 commits March 5, 2025 19:46
@ASuciuX
add clippy and fmt support CLI + rename commands
2d58ea1 
- update commands to bitcoin-indexer from ordhook
@ASuciuX
add clippy cli output
34aaef8
@ASuciuX
remove exit 1 from clippy ci
d597f6e
@ASuciuX
add rustfmt action, disable exit on error on clippy
8decaaf
@ASuciuX
update clippy job
4a3210d
@ASuciuX
clippy only show error and warning lines
f94f3dc
@ASuciuX
grep clippy errors when printing
e1a471d
@ASuciuX
preserve clippy output format
ae8c03d
@ASuciuX
write clippy output in a file and print it afterwards
afa122e
@ASuciuX
move clippy ci grep check
c0131db
@ASuciuX
add doctest ci job
e7f8154
@ASuciuX
fix actions naming
8b94b43
@ASuciuX
update ci
6bb7bcf
@ASuciuX
update to 1.85
d55faa5
@ASuciuX
create settings file to format Rust files on save
60239ef
@ASuciuX
change granularity to Crate from Module to align with repo structure
f9da074
@ASuciuX
format the codebase
b661d91
@ASuciuX
fix clippy errors + some warnings
4514a3b
@ASuciuX
fix clippy issues
d83303a
@ASuciuX ASuciuX force-pushed the feat/integrate-clippy-and-fmt branch from e91ec39 to d83303a Compare March 5, 2025 17:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

Vercel deployment URL: https://bitcoin-indexer-1go4qdrwz-hirosystems.vercel.app 🚀

rafaelcr
rafaelcr reviewed Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to fix the broken cli test before merging... do you know what is going on there?

@ASuciuX
Copy link
Contributor Author

ASuciuX commented Mar 6, 2025

The issue is that the setup for running cargo test --doc isn't configured in the CLI subproject. I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clippy Support
2 participants
@ASuciuX @rafaelcr