Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huber spline has problems with zero-crossing trend #64

Open
guyrixon opened this issue Sep 1, 2023 · 1 comment
Open

Huber spline has problems with zero-crossing trend #64

guyrixon opened this issue Sep 1, 2023 · 1 comment

Comments

@guyrixon
Copy link

guyrixon commented Sep 1, 2023

The flatten function computes the trend and then divides it into the input flux to get the output flux. That implies that the trend comes back from the estimator centred on a value of 1, but for Huber spline it doesn't; all the Huber-spline trends for my data are coming back centred on 0. This inevitably produces wild excursions in the middle where the trend is close to zero, even when the shape of the trend is reasonable.

@hippke
Copy link
Owner

hippke commented Sep 6, 2023

Can you check the example which has a huber spline application? In the example it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants