Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS-620: Fix image build error on staging #623

Merged
merged 1 commit into from
May 22, 2020
Merged

ISS-620: Fix image build error on staging #623

merged 1 commit into from
May 22, 2020

Conversation

Darius-Ndubi
Copy link
Contributor

@Darius-Ndubi Darius-Ndubi commented May 22, 2020

What is the Purpose?

Fix image failure build on staging

What was the approach?

Fix ECHO error on staging stating that command is not found

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@odenypeter @sannleen

Issue(s) affected?

None

@Darius-Ndubi Darius-Ndubi marked this pull request as ready for review May 22, 2020 18:37
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #623 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #623   +/-   ##
=======================================
  Coverage   51.01%   51.01%           
=======================================
  Files         126      126           
  Lines        8607     8607           
=======================================
  Hits         4391     4391           
  Misses       4216     4216           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad9155...f76fbe3. Read the comment docs.

@Darius-Ndubi Darius-Ndubi added the defect This doesn't seem right label May 22, 2020
@amosnjoroge amosnjoroge self-requested a review May 22, 2020 18:48
@Darius-Ndubi Darius-Ndubi merged commit 4b7dde8 into dev May 22, 2020
@Darius-Ndubi Darius-Ndubi deleted the ISS-620 branch May 22, 2020 18:51
@Darius-Ndubi Darius-Ndubi linked an issue Jun 25, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix image build failure
2 participants