Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing.md to update the coding convention #615

Open
ninetteadhikari opened this issue May 18, 2020 · 0 comments
Open

Update Contributing.md to update the coding convention #615

ninetteadhikari opened this issue May 18, 2020 · 0 comments
Labels
1 Insignificant task (very minimal effort and time needed)

Comments

@ninetteadhikari
Copy link
Member

ninetteadhikari commented May 18, 2020 •
edited
Loading

Coding conventions to be added
Update: https://github.com/hikaya-io/activity/blob/dev/CONTRIBUTING.md#coding-conventions

  • Exclude specific files from linting:
    • Model file
  • Code complexity review
    • Discuss to decide Flake 8 or PyLint as opposed to code climate
@ninetteadhikari ninetteadhikari added this to the Sprint 35 milestone May 18, 2020
@ninetteadhikari ninetteadhikari added 1 Insignificant task (very minimal effort and time needed) refactor Time to restructure some code! and removed refactor Time to restructure some code! labels May 18, 2020
@ninetteadhikari ninetteadhikari changed the title Update Contribution.md to update the coding convention Update Contributing.md to update the coding convention Jun 7, 2020
@andrewtpham andrewtpham modified the milestones: Sprint 35, Sprint 36 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 Insignificant task (very minimal effort and time needed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtpham @ninetteadhikari