Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start recording full resource timing #8534

Open
linear bot opened this issue May 10, 2024 · 2 comments
Open

Start recording full resource timing #8534

linear bot opened this issue May 10, 2024 · 2 comments

Comments

@linear
Copy link

linear bot commented May 10, 2024

also would be cool to use the PerformanceObserver API instead of polling for resources

Copy link
Author

linear bot commented May 10, 2024

Copy link

greptile-apps bot commented May 10, 2024

To implement full resource timing recording, follow these steps:

  1. Modify Network Listener Utilities (/sdk/client/src/listeners/network-listener/utils/utils.ts):

    • Update matchPerformanceTimingsWithRequestResponsePair to ensure it captures and associates all relevant performance timing details with each network request.
  2. Update First Load Listeners (/sdk/client/src/listeners/first-load-listeners.tsx):

    • In the FirstLoadListeners class, enhance the setupNetworkListener method to include capturing full resource timing information.
  3. Integrate with ResourcesContext (/frontend/src/pages/Player/ResourcesContext/ResourcesContext.tsx):

    • Ensure the useResources hook processes and includes the full resource timing data in its state, making it available to the consuming components.
  4. Display in UI (/frontend/src/pages/Player/RightPlayerPanel/components/NetworkResourcePanel/NetworkResourcePanel.tsx):

    • Adjust the NetworkResourcePanel, NetworkResourceDetails, and WebSocketDetails components to display the full resource timing information.

These steps target specific enhancements in the codebase to capture and display full resource timing, leveraging existing structures for network resource handling.

References

/frontend/src/pages/Player/ResourcesContext/ResourcesContext.tsx
/sdk/client/src/listeners/network-listener/utils/utils.ts
/frontend/src/pages/Player/RightPlayerPanel/components/NetworkResourcePanel/NetworkResourcePanel.tsx
/sdk/client/src/listeners/first-load-listeners.tsx

Ask Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants