Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph loading states broken #8533

Closed
linear bot opened this issue May 10, 2024 · 2 comments
Closed

graph loading states broken #8533

linear bot opened this issue May 10, 2024 · 2 comments

Comments

@linear
Copy link

linear bot commented May 10, 2024

showing up empty

Copy link
Author

linear bot commented May 10, 2024

Copy link

greptile-apps bot commented May 10, 2024

To address the issue with graph loading states appearing empty, review the implementation of graph loading and rendering logic in the following files:

  • DashboardOverview.tsx: Check the loading state handling within the useGetVisualizationsQuery hook and how LoadingBox or similar components are utilized.

  • GraphingEditor.tsx: Inspect the useGetVisualizationQuery and useGetKeysQuery hooks for loading state management. Ensure that loading indicators or placeholders are correctly implemented for asynchronous data fetching.

  • Dashboard.tsx: Verify the useGetVisualizationQuery hook's loading state and how graphs are conditionally rendered based on the loading flag or the presence of graph data.

Ensure that loading states are properly managed and that UI components responsible for displaying loading indicators are correctly implemented and rendered in the UI during data fetching.

References

/frontend/src/pages/Graphing/DashboardOverview.tsx
/frontend/src/pages/Graphing/GraphingEditor.tsx
/frontend/src/pages/Graphing/Dashboard.tsx

Ask Greptile

@linear linear bot closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants