Replies: 2 comments 4 replies
-
Hey @weizman, this seems very cool. And your example makes sense; we do support nested iframes in highlight.io. My initial reaction, however, is that since most of our browser-level instrumentation happens in our fork of https://github.com/rrweb-io/rrweb, SNOW may be a better fit there. Curious what @Vadman97 thinks. |
Beta Was this translation helpful? Give feedback.
2 replies
-
hey @weizman , thanks for sharing! rrweb would be a better fit overall for most of the recording logic, but we actually have a request to support console/network recording via monkey patch in iframes which we do ourselves, where this may be a fit. i'll take a look at your project when we get to this! |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Snow ❄️
In MetaMask 🦊 we are developing a JS security shim called Snow ❄️.
Snow exposes the simplest API to hook a callback to the event of new realms creation.
In other words, you can provide Snow a callback, and it will be invoked with the creation of every new iframe in the page:
Proposal
I think Snow integration into Highlight can be useful, so for example if you pass the entire Highlight clientside logic through Snow as a callback, and then change the XHR override from
const XHR = XMLHttpRequest.prototype
toconst XHR = win.XMLHttpRequest.prototype
(and so on) then Hightlight's logic of monitoring will apply not only to the top main realm but to inner iframes as well automatically with zero effort.This will allow you to enhance your visibility into iframes and other same origin realms in a page rather than only the main realm of the app.
Snow supports all major browsers and all major websites.
Discussion
I'd like your opinion on this, would be cool to see Snow being relevant somehow to this project (Snow is licensed as MIT)
Beta Was this translation helpful? Give feedback.
All reactions