Test schema, add min length to strings

hic-infra · May 22, 2024 · 08f2da1 · 08f2da1
1 parent 456fe2f
commit 08f2da1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/aws_project_costs/project-cost-schema.json b/aws_project_costs/project-cost-schema.json
@@ -1,14 +1,15 @@
 {
   "$schema": "http://json-schema.org/draft/2020-12/schema",
-  "$id": "https://github.com/hic-infra/TODO",
+  "$id": "https://github.com/hic-infra/hic-aws-project-cost",
   "title": "AWS project cost configuration",
   "type": "object",
   "properties": {
     "proj-tag-names": {
       "description": "A mapping of AWS project tags to the canonical project name",
       "type": "object",
       "additionalProperties": {
-        "type": "string"
+        "type": "string",
+        "minLength": 1
       }
     },
     "project-groups": {
@@ -17,7 +18,8 @@
       "additionalProperties": {
         "type": "array",
         "items": {
-          "type": "string"
+          "type": "string",
+          "minLength": 1
         }
       }
     },
@@ -29,7 +31,8 @@
         "properties": {
           "name": {
             "description": "Name of the AWS account",
-            "type": "string"
+            "type": "string",
+            "minLength": 1
           },
           "billing-type": {
             "description": "Whether costs should be split across multiple projects or assigned to a single project",
@@ -45,12 +48,14 @@
             "type": "array",
             "minItems": 1,
             "items": {
-              "type": "string"
+              "type": "string",
+              "minLength": 1
             }
           },
           "project": {
             "description": "The project responsible for all costs, required for billing-type=project-specific",
-            "type": "string"
+            "type": "string",
+            "minLength": 1
           }
         },
         "required": ["name", "billing-type"],

diff --git a/tests/test_project_costs.py b/tests/test_project_costs.py
@@ -4,12 +4,19 @@
 import yaml
 
 from aws_project_costs.project_costs import analyse_costs_csv
-
-# from aws_project_costs.schema import validate
+from aws_project_costs.schema import validate
 
 EXAMPLE_DIR = Path(__file__).parent / ".." / "example"
 
 
+def test_schema_validate():
+    config_yaml = EXAMPLE_DIR / "projects.yaml"
+    with (config_yaml).open() as f:
+        cfg = yaml.safe_load(f)
+    errors = validate(cfg, raise_on_error=False)
+    assert len(errors) == 0
+
+
 def test_analyse_costs_csv(tmp_path):
     config_yaml = EXAMPLE_DIR / "projects.yaml"
     input_csv = EXAMPLE_DIR / "2024-01-01_2024-02-01.csv"