From 8c9d091691b5b6064a17326d5293e25bafe88fe4 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Tue, 14 May 2024 17:13:55 +0100 Subject: [PATCH 1/4] Exclude `Enterprise Discount Program Discount` and `Solution Provider Program Discount` --- hic_aws_costing_tools/aws_costs.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hic_aws_costing_tools/aws_costs.py b/hic_aws_costing_tools/aws_costs.py index 1f36bbc..eb57d3f 100755 --- a/hic_aws_costing_tools/aws_costs.py +++ b/hic_aws_costing_tools/aws_costs.py @@ -6,7 +6,16 @@ DEFAULT_COST_TYPE = "UnblendedCost" DEFAULT_GRANULARITY = "MONTHLY" -DEFAULT_EXCLUDE_RECORD_TYPES = ["Credit", "Refund", "Tax"] +DEFAULT_EXCLUDE_RECORD_TYPES = [ + "Credit", + "Refund", + "Tax", + # These two aren't documented on + # https://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/manage-cost-categories.html#cost-categories-terms + # Waiting for confirmation from AWS Support that it's OK to use these + "Enterprise Discount Program Discount", + "Solution Provider Program Discount", +] EXPECTED_UNIT = "USD" From 4109d00308f976010a2b14687f1130fecf54ae96 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Thu, 13 Jun 2024 17:34:41 +0100 Subject: [PATCH 2/4] Update comment about undocumented discount record types --- hic_aws_costing_tools/aws_costs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hic_aws_costing_tools/aws_costs.py b/hic_aws_costing_tools/aws_costs.py index eb57d3f..d25a312 100755 --- a/hic_aws_costing_tools/aws_costs.py +++ b/hic_aws_costing_tools/aws_costs.py @@ -12,7 +12,7 @@ "Tax", # These two aren't documented on # https://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/manage-cost-categories.html#cost-categories-terms - # Waiting for confirmation from AWS Support that it's OK to use these + # but were confirmed in AWS Support ticket 171570162800825 "Enterprise Discount Program Discount", "Solution Provider Program Discount", ] From 2dc1fe5d7bf0ad369fd018dc7167f17aa2164e0a Mon Sep 17 00:00:00 2001 From: Simon Li Date: Thu, 13 Jun 2024 17:40:06 +0100 Subject: [PATCH 3/4] Add 0.2.0 changelog --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 669e208..d89e785 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## 0.2.0 - 2024-06-16 + +### Breaking + +- Add `Enterprise Discount Program Discount` and `Solution Provider Program Discount` to the list of default excluded record types [#6](https://github.com/hic-infra/hic-aws-costing-tools/pull/6). + To revert to the previous behaviour pass `--exclude-types Credit Refund Tax` + ## 0.1.0 - 2024-04-24 Release 0.1.0 From 683055184a58f33f7c5f5908fd5d34a46231c4a8 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Tue, 18 Jun 2024 12:11:21 +0100 Subject: [PATCH 4/4] 0.2.0 date: 2024-06-18 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d89e785..47ac840 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## 0.2.0 - 2024-06-16 +## 0.2.0 - 2024-06-18 ### Breaking