Can't compare empty list [], check length 0

manics · manics · commit 29340d12e7ba · 2024-04-24T12:34:52.000+01:00
diff --git a/ecs-cluster/keycloak.tf b/ecs-cluster/keycloak.tf
@@ -5,8 +5,8 @@ locals {
   keycloak-hostname = var.keycloak-hostname == "" ? aws_lb.keycloak.dns_name : var.keycloak-hostname
 
   vpc_id          = var.vpc-id == "" ? module.vpc[0].vpc_id : var.vpc-id
-  public_subnets  = var.public-subnets == [] ? module.vpc[0].public_subnets : var.public-subnets
-  private_subnets = var.private-subnets == [] ? module.vpc[0].private_subnets : var.private-subnets
+  public_subnets  = length(var.public-subnets) == 0 ? module.vpc[0].public_subnets : var.public-subnets
+  private_subnets = length(var.private-subnets) == 0 ? module.vpc[0].private_subnets : var.private-subnets
 }
 
 resource "random_password" "db-password" {

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,8 @@ locals {`
`5`	`5`	`keycloak-hostname = var.keycloak-hostname == "" ? aws_lb.keycloak.dns_name : var.keycloak-hostname`
`6`	`6`
`7`	`7`	`vpc_id = var.vpc-id == "" ? module.vpc[0].vpc_id : var.vpc-id`
`8`		`- public_subnets = var.public-subnets == [] ? module.vpc[0].public_subnets : var.public-subnets`
`9`		`- private_subnets = var.private-subnets == [] ? module.vpc[0].private_subnets : var.private-subnets`
	`8`	`+ public_subnets = length(var.public-subnets) == 0 ? module.vpc[0].public_subnets : var.public-subnets`
	`9`	`+ private_subnets = length(var.private-subnets) == 0 ? module.vpc[0].private_subnets : var.private-subnets`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`resource "random_password" "db-password" {`