-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Allow redirects to repos #1028
Comments
I think |
We should be handling redirects: Line 113 in 0a5c49f
|
I'm still seeing the error reported above; but perhaps it is not in fact related to redirects. I will try to set up a repro this week. |
@christhekeele Did you learn anything more about this? |
I started to try to reproduce the error above with DNS on a domain I control personally, but then got distracted by the chore of waiting for DNS to propagate from my fairly slow provider 😅 I will get back on the horse this weekend and sort out the repro |
Yup, for some reason I just cannot get this error to raise:
with an open setup, so I have to assume there is something unique at the network level causing it. I will mark this feature request as closed, since as @ericmj points out, the code should already handle redirects and I was just looking in the wrong place when triaging my error. I will open a new issue if I can get a reliable repro with a more specific synopsis! |
Usecase
https://fly.storage.tigris.dev/my-hex-registry
302
redirect set up to it likehttps://hex.example.com
to hide the storage implementation detailsmix hex.repo add my-hex https://hex.example.com
to work instead of requiring the precise bucket locationCurrent Behaviour
Today I just get an error after about 30 seconds of what I assume is retrying in
Mix.install
:Error
Providing the full storage location works fine.
I believe this could be fixed in
Hex.HTTP
by giving:httpc
theautoredirect: true
option; it is given false today.Proposal
I assume it is enforced off today for security and trust reasons I am not fluent in. I think it would be nice to make this opt-in configurable, unless doing so has implications lost on me that would compromise hex's general trust model.
I would propose parameterizing it, defaulting to
false
, via env vars similar toHEX_UNSAFE_REGISTRY=1
. Perhaps something likeHEX_FOLLOW_REDIRECTS=1
?The text was updated successfully, but these errors were encountered: