From 2ade7aa1f031a5f94ad8111c2992bf85785d7065 Mon Sep 17 00:00:00 2001 From: object-Object Date: Sun, 5 Nov 2023 14:47:05 -0500 Subject: [PATCH] okay just don't run it then. fine --- .github/workflows/ci.yml | 10 ++++++---- .pre-commit-config.yaml | 2 -- noxfile.py | 4 +++- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 90573fcb..efd66b25 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,11 +23,13 @@ jobs: with: python-version: '3.11' - - name: Install dependencies - run: pip install . nox - - - name: Run pre-commit + - name: Run pre-commit hooks + env: + SKIP: pyright uses: pre-commit/action@v3.0.0 + - name: Install Nox + run: pip install nox + - name: Run Nox run: nox diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index baa9f650..4dcb8fb0 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -18,5 +18,3 @@ repos: - id: pyright args: ["--warnings"] files: '^src/' - additional_dependencies: - - "." diff --git a/noxfile.py b/noxfile.py index a959f458..b8640089 100644 --- a/noxfile.py +++ b/noxfile.py @@ -5,7 +5,9 @@ def tests(session: nox.Session): session.install("-e", ".[test]", "-e", "./test/_submodules/HexMod") - session.run("pytest", *session.posargs) + # this apparently CANNOT run from pre-commit in GitHub Actions (venv issues) + session.run("pyright", "src", "--warnings") # test cookiecutter last so the extra package install doesn't interfere + session.run("pytest", *session.posargs) session.run("pytest", "-k", "test_cookiecutter", "--nox", *session.posargs)