feat: update to node 22 #3337
Open
feat: update to node 22 #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbosio
approved these changes
Jul 17, 2025
eablack
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
eablack
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
* Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command
… account for new default rules
… account for new default rules
eablack
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
eablack
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-18293846
Description
This updates v11 to be compatible with both node 20 and node 22. It will ship with node 22. This also updates eslint to v8, and brings numerous formatting changes to files to satisfy updated rules. I did limit the number of changes required by switching many rules to
warn.Testing
You may need to add a new version of node to your asdf before testing.
yarn install and yarn build./bin/run whoami