Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'heroku-run' should accept callbacks for its API queries instead of accepting a client object #1301

Open
vedantgoyal opened this issue Aug 21, 2019 · 0 comments

Comments

@vedantgoyal
Copy link

Do you want to request a feature or report a bug?

enahncement

What is the current behavior?

'heroku-run' exports a Dyno class to create new dynos or run commands inside existing dynos. It takes a parameter called 'heroku' which is the api client used by the Dyno class to create or find a dyno.

What is the expected behavior?

It would be preferable for the Dyno class to take api callbacks as a parameter instead. This will make reusing this module much simpler. Currently a heroku client has to be emulated and passed as a parameter to make different api calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant