build CKEditor5 simply with basic function that compatible with CKEditor4 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I read the issue #39 and i'm asking, what's the status of this PR please ? |
@abdounasser202 I'm thinking of providing a separate class for CKEditor 5 (something like helloflask/bootstrap-flask#161), so that we don't need to set a default value for @WebberMao Thanks for working on this. Could you refactor to use different extension classes for different versions? By the way, I notice you rewrite the whole file, it makes git can't diff the changes. |
|
@greyli Sure, it may take some time. I will post another RP later. |
|
Thank you, there is no hurry. Please also use separate PRs for different tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR done the following jobs
The user can switch the version of CKEditor by setting
app = CKEditor(app, version=4) #version=4 in defaultapp = CKEditor(app, version=5)and change the editor_type (support CKEditor5 only) by setting config
CKEDITOR_EDITOR_TYPE = 'classic' #and all the other typeshope you will like it!