Track "weird routes" for manual intervention

Author: macpie

include/hpr_metrics.hrl

@@ -13,6 +13,7 @@
 -define(METRICS_ROUTES_GAUGE, "hpr_routes_gauge").
 -define(METRICS_EUI_PAIRS_GAUGE, "hpr_eui_pairs_gauge").
 -define(METRICS_SKFS_GAUGE, "hpr_skfs_gauge").
+-define(METRICS_WEIRD_ROUTES_GAUGE, "hpr_weird_routes_gauge").
 -define(METRICS_PACKET_REPORT_HISTOGRAM, "hpr_packet_report_histogram").
 -define(METRICS_MULTI_BUY_GET_HISTOGRAM, "hpr_multi_buy_get_histogram").
 -define(METRICS_FIND_ROUTES_HISTOGRAM, "hpr_find_routes_histogram").
@@ -35,6 +36,7 @@
     {?METRICS_ROUTES_GAUGE, prometheus_gauge, [], "Number of Routes"},
     {?METRICS_EUI_PAIRS_GAUGE, prometheus_gauge, [], "Number of EUI Pairs"},
     {?METRICS_SKFS_GAUGE, prometheus_gauge, [], "Number of SKFs"},
+    {?METRICS_WEIRD_ROUTES_GAUGE, prometheus_gauge, [], "Number of weird routes"},
     {?METRICS_PACKET_REPORT_HISTOGRAM, prometheus_histogram, [status], "Packet Reports"},
     {?METRICS_MULTI_BUY_GET_HISTOGRAM, prometheus_histogram, [status], "Multi Buy Service Get"},
     {?METRICS_FIND_ROUTES_HISTOGRAM, prometheus_histogram, [], "Find Routes"},

src/metrics/hpr_metrics.erl

@@ -187,6 +187,7 @@ handle_info(?METRICS_TICK, State) ->
         fun record_routes/0,
         fun record_eui_pairs/0,
         fun record_skfs/0,
+        fun record_weird_routes/0,
         fun record_ets/0,
         fun record_queues/0,
         fun record_devices/0
@@ -278,6 +279,36 @@ record_skfs() ->
     _ = prometheus_gauge:set(?METRICS_SKFS_GAUGE, [], Count),
     ok.
 
+-spec record_weird_routes() -> ok.
+record_weird_routes() ->
+    Count = lists:foldl(
+        fun(RouteETS, Acc) ->
+            Route = hpr_route_ets:route(RouteETS),
+            RouteID = hpr_route:id(Route),
+            SKFCount =
+                case ets:info(hpr_route_ets:skf_ets(RouteETS), size) of
+                    undefined -> 0;
+                    N -> N
+                end,
+            DevAddrRangesCount = hpr_devaddr_range_storage:count_for_route(RouteID),
+            case SKFCount > 0 andalso DevAddrRangesCount == 0 of
+                true ->
+                    lager:critical(
+                        [{route_id, RouteID}, {oui, hpr_route:oui(Route)}],
+                        "route has no devaddr ranges but has (~p) skfs",
+                        [SKFCount]
+                    ),
+                    Acc + 1;
+                false ->
+                    Acc
+            end
+        end,
+        0,
+        ets:tab2list(hpr_routes_ets)
+    ),
+    _ = prometheus_gauge:set(?METRICS_WEIRD_ROUTES_GAUGE, [], Count),
+    ok.
+
 -spec record_grpc_connections() -> ok.
 record_grpc_connections() ->
     Opts = application:get_env(grpcbox, listen_opts, #{}),