Skip to content

Commit de1c9de

Browse files
committed
Changed schema encoding to utf-8
1 parent 790686d commit de1c9de

12 files changed

+31
-31
lines changed

deploy_hed/requirements.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
flask>=3.0.2
1+
flask>=3.0.3
22
flask-wtf>=1.2.1
33
config>=0.5.1
44
mod_wsgi>=4.9.0
55
openpyxl>=3.1.2
66
pandas>=2.2.0
7-
Werkzeug>=3.0.1
7+
Werkzeug>=3.0.3
88
requests>=2.31.0

deploy_hed_dev/requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
flask>=3.0.2
1+
flask>=3.0.3
22
flask-wtf>=1.2.1
33
config>=0.5.1
44
mod_wsgi>=4.9.0

docs/requirements.txt

+17-17
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11
attrs>=21.4.0
2-
click==8.1.3
2+
click>=8.1.3
33
coverage>=6.3.2
4-
defusedxml==0.7.1
5-
et-xmlfile==1.1.0
6-
Flask==2.1.2
7-
Flask-WTF==1.0.1
4+
defusedxml>=0.7.1
5+
et-xmlfile>=1.1.0
6+
Flask>=3.0.3
7+
Flask-WTF>=1.2.1
88
inflect>=5.5.2
9-
itsdangerous==2.1.2
10-
jdcal==1.4.1
9+
itsdangerous>=2.2.0
10+
jdcal>=1.4.1
1111
Jinja2>=3.1.2
1212
MarkupSafe==2.1.1
1313
myst-parser>=0.17.0
1414
numpy>=1.20.3
15-
numpydoc==1.3.1
15+
numpydoc>=1.3.1
1616
openpyxl>=3.0.9
1717
pandas>=1.3.5
18-
portalocker==2.4.0
19-
Pygments==2.12.0
20-
python-dateutil==2.8.2
21-
pytz==2022.1
18+
portalocker>=2.8.2
19+
Pygments>=2.12.0
20+
python-dateutil>=2.8.2
21+
pytz>=2022.1
2222
semantic_version>=2.9.0
2323
six==1.16.0
2424
Sphinx>=4,<5
25-
SphinxExtensions==0.2.0
26-
sphinx_rtd_theme==1.0.0
27-
Werkzeug==2.1.2
28-
WTForms==3.0.1
29-
xlrd==2.0.1
25+
SphinxExtensions>=0.2.0
26+
sphinx_rtd_theme>=1.0.0
27+
Werkzeug>=2.1.2
28+
WTForms>=3.0.1
29+
xlrd>=2.0.1

hedweb/process_form.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def set_schema_from_request(arguments, request):
117117
elif form_has_option(request.form, bc.SCHEMA_VERSION) and form_has_file(request.files, bc.SCHEMA_PATH):
118118
f = request.files[bc.SCHEMA_PATH]
119119
arguments[bc.SCHEMA] = \
120-
from_string(f.read(fc.BYTE_LIMIT).decode('ascii'), schema_format=secure_filename(f.filename))
120+
from_string(f.read(fc.BYTE_LIMIT).decode('utf-8'), schema_format=secure_filename(f.filename))
121121
if form_has_option(request.form, bc.SCHEMA_UPLOAD_OPTIONS, bc.SCHEMA_FILE_OPTION) and \
122122
form_has_file(request.files, bc.SCHEMA_FILE, fc.SCHEMA_EXTENSIONS):
123123
arguments[bc.SCHEMA] = ProcessForm.get_schema(request.files[bc.SCHEMA_FILE])
@@ -148,7 +148,7 @@ def get_schema(schema_input=None, version=None, as_xml_string=None):
148148
"""
149149
if isinstance(schema_input, FileStorage):
150150
name, extension = get_parsed_name(secure_filename(schema_input.filename))
151-
hed_schema = hedschema.from_string(schema_input.read(fc.BYTE_LIMIT).decode('ascii'),
151+
hed_schema = hedschema.from_string(schema_input.read(fc.BYTE_LIMIT).decode('utf-8'),
152152
schema_format=extension,
153153
name=name)
154154
elif isinstance(schema_input, str):

hedweb/routes.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def schema_version_results():
101101
if bc.SCHEMA_PATH in request.files:
102102
f = request.files[bc.SCHEMA_PATH]
103103
name, extension = get_parsed_name(secure_filename(f.filename))
104-
hed_schema = hedschema.from_string(f.stream.read(file_constants.BYTE_LIMIT).decode('ascii'),
104+
hed_schema = hedschema.from_string(f.stream.read(file_constants.BYTE_LIMIT).decode('utf-8'),
105105
schema_format=extension)
106106
hed_info[bc.SCHEMA_VERSION] = hed_schema.get_formatted_version()
107107
return json.dumps(hed_info)

hedweb/schema_operations.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def get_schema(schema_input=None, version=None, as_xml_string=None):
148148
"""
149149
if isinstance(schema_input, FileStorage):
150150
name, extension = get_parsed_name(secure_filename(schema_input.filename))
151-
hed_schema = hedschema.from_string(schema_input.read(fc.BYTE_LIMIT).decode('ascii'),
151+
hed_schema = hedschema.from_string(schema_input.read(fc.BYTE_LIMIT).decode('utf-8'),
152152
schema_format=extension,
153153
name=name)
154154
elif isinstance(schema_input, str):

hedweb/web_util.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ def get_hed_schema_from_pull_down(request):
270270
hed_schema = load_schema_version(request.form[bc.SCHEMA_VERSION])
271271
elif bc.SCHEMA_PATH in request.files:
272272
f = request.files[bc.SCHEMA_PATH]
273-
hed_schema = hedschema.from_string(f.read(fc.BYTE_LIMIT).decode('ascii'),
273+
hed_schema = hedschema.from_string(f.read(fc.BYTE_LIMIT).decode('utf-8'),
274274
schema_format=secure_filename(f.filename))
275275
else:
276276
raise HedFileError("NoSchemaFile", "Must provide a valid schema for upload if other chosen", "")

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
flask>=3.0.2
1+
flask>=3.0.3
22
flask-wtf>=1.2.1
33
config>=0.5.1
44
openpyxl>=3.1.2

services_tests/test_services_base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def _get_path(self, filename):
8080
def _get_file_string(self, filename):
8181
filename = self._get_path(filename)
8282
with open(filename, 'rb') as fp:
83-
filename_string = fp.read().decode('ascii')
83+
filename_string = fp.read().decode('utf-8')
8484

8585
return filename_string
8686

tests/test_routes/test_routes_base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ def _get_file_buffer(self, filename, name=None):
2828
def _get_file_string(self, filename):
2929
filename = self._get_path(filename)
3030
with open(filename, 'rb') as fp:
31-
filename_string = fp.read().decode('ascii')
31+
filename_string = fp.read().decode('utf-8')
3232

3333
return filename_string

tests/test_services.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def test_set_input_from_service_request(self):
4545
with self.app.test:
4646
sidecar_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data/bids_events.json')
4747
with open(sidecar_path, 'rb') as fp:
48-
sidecar_string = fp.read().decode('ascii')
48+
sidecar_string = fp.read().decode('utf-8')
4949
json_data = {bc.SIDECAR_STRING: sidecar_string, bc.CHECK_FOR_WARNINGS: 'on',
5050
bc.SCHEMA_VERSION: '8.2.0', bc.SERVICE: 'sidecar_validate'}
5151
environ = create_environ(json=json_data)
@@ -61,7 +61,7 @@ def test_set_input_from_service_request_full_template(self):
6161
with self.app.test:
6262
sidecar_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data/bids_events.json')
6363
with open(sidecar_path, 'rb') as fp:
64-
sidecar_string = fp.read().decode('ascii')
64+
sidecar_string = fp.read().decode('utf-8')
6565
json_data = self.get_request_template()
6666
json_data[bc.SIDECAR_STRING] = sidecar_string
6767
json_data[bc.CHECK_FOR_WARNINGS] = True,

tests/test_web_util.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def test_generate_text_response(self):
220220
"generate_download_download_text_response should return text")
221221
self.assertEqual(results[bc.MSG], headers_dict['Message'],
222222
"generate_download_text_response have the correct message in the response")
223-
self.assertEqual(results['data'], response.data.decode('ascii'),
223+
self.assertEqual(results['data'], response.data.decode('utf-8'),
224224
"generate_download_text_response have the download text as response data")
225225

226226
def test_get_hed_schema_from_pull_down_empty(self):

0 commit comments

Comments
 (0)