Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Definitions be allowed to have empty contents? Must resolve. #611

Open
VisLab opened this issue Aug 23, 2024 · 0 comments
Open

Should Definitions be allowed to have empty contents? Must resolve. #611

VisLab opened this issue Aug 23, 2024 · 0 comments

Comments

@VisLab
Copy link
Member

VisLab commented Aug 23, 2024

The tests assume that they should have non-empty contents:

DEFINITION_INVALID definition-invalid-missing-inner-group: Example:

{
  "defs": {
    "HED": {
      "def1": "(Definition/Apple)"
    }
  }
}

There is an argument that this should be allowed to so that you can anchor onsets and offsets without actually having to put content in the definition. The hed-validator doesn't treat this as an error, but the hed-python validator does at this point..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant